[FEAT][distributed]: add deterministic ROCm/RCCL transport collectives - #356
Open
Flink-ddd wants to merge 6 commits into
Open
[FEAT][distributed]: add deterministic ROCm/RCCL transport collectives#356Flink-ddd wants to merge 6 commits into
Flink-ddd wants to merge 6 commits into
Conversation
Flink-ddd
requested review from
EthanZero2Hero,
KJLdefeated,
bitborne and
inaniloquentee
as code owners
August 28, 2026 16:56
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Flink-ddd
requested review from
CyberSecurityErial,
frank-2077,
maxiaosong1124 and
zhangj1an
August 28, 2026 16:58
Signed-off-by: vensen <vensenmu@gmail.com>
40 tasks
Signed-off-by: vensen <vensenmu@gmail.com>
Signed-off-by: vensen <vensenmu@gmail.com>
maxiaosong1124
added a commit
to maxiaosong1124/RL-Kernel
that referenced
this pull request
Aug 30, 2026
Signed-off-by: maxiaosong1124 <maxiaosong7890@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a standalone deterministic communication implementation for ROCm, separated from the ROCm GEMM work.
Design
RCCL is used only to transport rank-ordered input tensors through all_gather_into_tensor. Floating-point reduction is performed locally using:
This avoids depending on RCCL's implementation-defined floating-point reduction order and matches the rank tree used by the CUDA deterministic collectives.
For performance:
Compute/communication fusion
This PR does not claim compute/communication fusion or asynchronous overlap.
The strict path completes rank-ordered RCCL transport before evaluating the fixed reduction tree. Native RCCL reduction, arbitrary arrival-order merging, and ROCm fused collectives are intentionally not used because they do not provide the required fixed floating-point parenthesization.
A future HIP/XGMI implementation can replace the transport behind the same factory after preserving the deterministic contract.
Validation
Multi-GPU MI300 performance numbers are not included because the development environment did not expose AMD GPUs. The PR includes benchmarks/benchmark_rocm_collectives.py for running the measurement.
Benchmark
The report contains:
Native RCCL is a performance reference, not the strict arithmetic oracle.