kw2xrf: use static inline#7108
Merged
Merged
Conversation
cgundogan
added
Platform: ARM
cgundogan
added
the
CI: ready for build
Member
|
I don't see why the linking failures happened in the first place. |
Member
|
@gebart because multiple c-files include Maybe it even makes more sense to not make these functions inline. This should however be evaluated with a size check. |
Member
|
I see. I would have expected it to become multiple definition rather than undefined reference. |
Member
|
It's possible this affects my #7107 as well. |
smlng
approved these changes
May 30, 2017
Member
smlng
left a comment
smlng
left a comment
There was a problem hiding this comment.
ACK, (still) works with gcc 5 and 6
Member
Author
|
murdock agrees - GO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7090