Skip to content

boards/nrf5340dk-app: Map out saul_gpio#22290

Merged
chrysn merged 1 commit into
RIOT-OS:masterfrom
chrysn-pull-requests:nrf5340dk-saul
May 13, 2026
Merged

boards/nrf5340dk-app: Map out saul_gpio#22290
chrysn merged 1 commit into
RIOT-OS:masterfrom
chrysn-pull-requests:nrf5340dk-saul

Conversation

@chrysn
Copy link
Copy Markdown
Member

@chrysn chrysn commented May 13, 2026

Contribution description

All the Nordic DKs have 4 buttons and 4 LEDs, but for the nRF5340 they were not mapped out.

One could set up PWMs to make the LEDs dimmable, but let's not have the better be the enemy of the good, and also, I don't know how to translate Fleißaufgabe.

Testing procedure

Running the SAUL example:

> saul
saul
ID      Class           Name
#0      SENSE_BTN       Button 1
#1      SENSE_BTN       Button 2
#2      SENSE_BTN       Button 2
#3      SENSE_BTN       Button 4
#4      ACT_SWITCH      LED1
#5      ACT_SWITCH      LED2
#6      ACT_SWITCH      LED3
#7      ACT_SWITCH      LED4
> saul read 0
saul read 0
Reading from #0 (Button 1|SENSE_BTN)
Data:                 0 
> saul write 4 1
saul write 4 1
Writing to device #4 - LED1
Data:                 1 
data successfully written to device #4

(And to be thorough, I wrote to all the LEDs in sequence to check their maping, and did the read-all for every single pressed button.)

Issues/PRs references

Based on #22289

Declaration of AI-Tools / LLMs usage:

AI-Tools / LLMs that were used are:

  • none

@github-actions github-actions Bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports labels May 13, 2026
@chrysn chrysn added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: SAUL Area: Sensor/Actuator Uber Layer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation and removed Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: cpu Area: CPU/MCU ports labels May 13, 2026
@riot-ci
Copy link
Copy Markdown

riot-ci commented May 13, 2026

Murdock results

✔️ PASSED

ed494ca boards/nrf5340dk-app: Map buttons and LEDs through SAUL

Success Failures Total Runtime
565 0 565 04m:54s

Artifacts

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't have to be part of this PR, does it?

Because if it doesn't, I'd trust your testing and merge the changes already before the situation in #22289 is resolved 🤔 🤷‍♂️

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, sorry -- it only mattered for my extra tests.

I'm taking the liberty to rebase, as things are just messy otherwise.

@github-actions github-actions Bot removed the Area: SAUL Area: Sensor/Actuator Uber Layer label May 13, 2026
@chrysn chrysn enabled auto-merge May 13, 2026 10:55
@chrysn chrysn added this pull request to the merge queue May 13, 2026
Merged via the queue into RIOT-OS:master with commit a088757 May 13, 2026
27 checks passed
@chrysn chrysn deleted the nrf5340dk-saul branch May 13, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants