boards/nrf5340dk-app: Map out saul_gpio#22290
Merged
Merged
Conversation
crasbe
reviewed
May 13, 2026
Contributor
There was a problem hiding this comment.
This doesn't have to be part of this PR, does it?
Because if it doesn't, I'd trust your testing and merge the changes already before the situation in #22289 is resolved 🤔 🤷♂️
Member
Author
There was a problem hiding this comment.
Indeed, sorry -- it only mattered for my extra tests.
I'm taking the liberty to rebase, as things are just messy otherwise.
crasbe
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
All the Nordic DKs have 4 buttons and 4 LEDs, but for the nRF5340 they were not mapped out.
One could set up PWMs to make the LEDs dimmable, but let's not have the better be the enemy of the good, and also, I don't know how to translate Fleißaufgabe.
Testing procedure
Running the SAUL example:
(And to be thorough, I wrote to all the LEDs in sequence to check their maping, and did the read-all for every single pressed button.)
Issues/PRs references
Based on #22289
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are: