.github/workflows: rebase before running static test#22255
Merged
Conversation
crasbe
added
Type: enhancement
github-actions
Bot
added
the
Area: CI
crasbe
force-pushed
the
pr/rebase_for_static_test_workflow
branch
from
e3da00c to
71b65fe
Compare
Contributor
Author
|
Okay, I'm happy now. The commits in the first line after the 
|
maribu
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The
static-testworkflow has a tendency to fail when the PR is not up to date with themasterbranch anymore, for example for thebuildsystem_sanity_checkwhen the Docker image was updated,doccheckwhen documentation has been fixed elsewhere orcodespellwhen typos have been fixed elsewhere.This forces contributors to rebase their PR, which sometimes leads to issues (especially for people who are not super experienced with git yet).
Also it is annoying and somewhat unnecessary because Murdock rebases the PR before running the static tests again anyways.
Testing procedure
I guess we should see that this PR does not fail the
static-testsworkflow.I deliberately dropped the last Riotdocker bump commit from the history of this branch, so the
buildsystem_sanity_checkshould fail without the changes. Let's see how this goes :DIssues/PRs references
As discussed in #22250.
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are: