gnrc/[gomach,lwmac]: Remove unused queue size option

[leandrolanzieri]

Contribution description

This removes the IPC message queue size configuration options from GoMacH and LWMAC modules as they are not used:

• CONFIG_GNRC_GOMACH_IPC_MSG_QUEUE_SIZE_EXP
• GNRC_GOMACH_IPC_MSG_QUEUE_SIZE
• CONFIG_GNRC_LWMAC_IPC_MSG_QUEUE_SIZE_EXP
• GNRC_LWMAC_IPC_MSG_QUEUE_SIZE

Testing procedure

• Green CI
• Test applications should compile and work as usual as the parameters are not used at all

Issues/PRs references

Spotted while reviewing #14104

[fjmolinas]

Git grep shows no occurrence other than the ones removed in this pr. ACK

git grep GNRC_GOMACH_IPC_MSG_QUEUE_SIZE
sys/include/net/gnrc/gomach/gomach.h:#ifndef CONFIG_GNRC_GOMACH_IPC_MSG_QUEUE_SIZE_EXP
sys/include/net/gnrc/gomach/gomach.h:#define CONFIG_GNRC_GOMACH_IPC_MSG_QUEUE_SIZE_EXP        (3U)
sys/include/net/gnrc/gomach/gomach.h:#ifndef GNRC_GOMACH_IPC_MSG_QUEUE_SIZE
sys/include/net/gnrc/gomach/gomach.h:#define GNRC_GOMACH_IPC_MSG_QUEUE_SIZE  (1 << CONFIG_GNRC_GOMACH_IPC_MSG_QUEUE_SIZE_EXP)

Seems like they where unused in the original PR as well, might we be missing something?

[fjmolinas]

I took a look at the original PR #5618 makes me think at first it used some quind of custom message queue that was later adapted to use pktsnip, and therefore maybe the define became unused, maybe @miri64 has an idea.

[miri64]

I took a look at the original PR #5618 makes me think at first it used some quind of custom message queue that was later adapted to use pktsnip, and therefore maybe the define became unused, maybe @miri64 has an idea.

No, these are macros for the IPC message queue. The modules where implemented right in the transition period of gnrc_netif, so I can imagine, that originally they were intended to be used with msg_init_queue() in a dedicated lwmac/gomach thread. However, they now use the gnrc_netif queue definitions, so I guess they really are not needed.

[miri64]

ACK from my side. Both protocols still build when used with examples/gnrc_networking_mac for samr21-xpro

[leandrolanzieri]

Thanks for the review!