fix: report IsGitRepo in worktrees and submodules (iss-72) - #34
Merged
Conversation
core.Status used isDir(.git), but .git is a regular gitfile (a gitlink), not a directory, in a linked git worktree (git worktree add) or a submodule checkout. A genuine checkout was reported IsGitRepo=false. Test existence instead of dir-ness for .git via a new exists() helper; HasRecord/WorkTiers stay dir-only. Assisted-by: Claude:claude-opus-4-8
Assisted-by: Claude:claude-opus-4-8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves iss-72 (native ledger).
core.StatusreportedIsGitRepoviaisDir(.git), but.gitis a regular gitfile (a gitlink), not a directory, in a linked git worktree (git worktree add) or a submodule checkout — so a genuine checkout read asIsGitRepo=false. The fix tests existence (file or dir) for.gitvia a newexists()helper;HasRecord/WorkTiersstay dir-only.os.Stat(follows symlinks) is correct — a dangling.gitsymlink still reads as not-a-repo.TDD:
TestStatusGitfileWorktreewrites a regular.gitgitfile and assertsIsGitRepo=true(fails on revert toisDir).make preflight+make record-lintgreen. Reviewed: ruthless SHIP (no trust boundary, so no security review).Assisted-by: Claude:claude-opus-4-8