feat: self-discovering CLI smoke harness (evals/) + eval intent (itd-75) - #2
Merged
Conversation
A smoke test that builds the real abcd binary, walks the Cobra command tree in-process via cli.NewRootCommand() (so new commands are covered with no edit), and exercises each against the binary: every command's --help must render without panicking, read-only verbs (version, status board) run for real, and an unknown flag degrades to a clean non-zero. Catches "compiles but panics on invocation", which the unit lane misses. Behind the `smoke` build tag so it stays out of `go test ./...`. Wired into a dedicated CI `smoke` job, the release verify gate (smokes the tagged-commit binary before publish), and `make smoke`. evals/data/ is reserved for the v2 fixture-driven scenarios. itd-75 captures the generalisation: abcd manages this harness for any repo it configures, with fixture-driven scenarios auto-discovered from evals/data/. This repo is the v1 dogfood.
REPPL
added a commit
that referenced
this pull request
Jul 11, 2026
feat: self-discovering CLI smoke harness (evals/) + eval intent (itd-75)
REPPL
added a commit
that referenced
this pull request
Jul 12, 2026
docs: itd-82 (abcd drain — ledger triage) + drain #2 run plan
REPPL
added a commit
that referenced
this pull request
Jul 12, 2026
docs: add iss-73 to drain #2 scope + capture iss-80
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A smoke harness that exercises the assembled binary through its whole command surface — the check unit tests can't give you.
What it does (v1)
Builds
abcd, then walks the Cobra tree in-process viacli.NewRootCommand()to discover every command + flag (new commands covered automatically, no hand-kept list), and against the built binary:--helpexits 0, produces output, never panics (the "compiles but crashes on invocation" catch),version, bare status board) run for real to a graceful exit,Proven locally: 21 discovered commands smoke green in ~1.2s.
Wiring
smokebuild tag → stays out of the fastgo test ./...lane.smokeCI job, a leg in the release verify gate (smokes the tagged-commit binary before publish — your "build & run the actual artifact" idea), andmake smoke.evals/data/reserved (with a README) for v2 fixtures.itd-75
Draft intent for the generalisation: abcd manages this harness for any repo it configures, with fixture-driven scenarios auto-discovered from
evals/data/. This repo is the v1 dogfood.Verification:
build/vet/test/make smoke/record-lint/docs lintgreen; zizmor clean on both edited workflows.Assisted-by: Claude