fix(tools): add bash/sh aliases for shell tool and migrate legacy tool names#2029
Closed
echoVic wants to merge 5 commits intoQwenLM:mainfrom
Closed
fix(tools): add bash/sh aliases for shell tool and migrate legacy tool names#2029echoVic wants to merge 5 commits intoQwenLM:mainfrom
echoVic wants to merge 5 commits intoQwenLM:mainfrom
Conversation
added 4 commits
March 1, 2026 11:19
QwenLM#2025) - Trim skill name in validateToolParams to handle cases where model adds extra whitespace - Update params.skill with trimmed value for consistent usage throughout the tool - Add test cases for leading/trailing whitespace and Chinese skill names Fixes QwenLM#2025
… API errors (QwenLM#2020) - Add PDF (application/pdf) to unsupported media types in convertUnsupportedMediaToText - This prevents 'Invalid value: file' API errors when reading PDF files - PDF content in tool responses is now converted to explanatory text - Add test cases for PDF inlineData and fileData conversion Fixes QwenLM#2020
…l names (QwenLM#2012) - Add 'bash' and 'sh' to ToolNamesMigration as aliases for run_shell_command - Migrate legacy tool names in CoreToolScheduler before registry lookup - This fixes 'Tool "bash" not found in registry' errors when models use common aliases - Add test case for tool name migration Fixes QwenLM#2012
echoVic
requested review from
DennisYu07,
LaZzyMan,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
This was referenced Mar 1, 2026
Collaborator
|
I think proficient tool usage capability is essential for model to prevail in all sorts of tasks, and we believe most up to date models have some capability. We have no plan for such workaround if some model is having trouble with tool use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Models often use common shell command aliases like
bashorshinstead of the registered tool namerun_shell_command, causing "Tool not found in registry" errors.Example error from #2012:
Changes
bashandshtoToolNamesMigrationas aliases forrun_shell_commandCoreToolScheduler._schedule()before registry lookupTesting
bashtool calls are correctly mapped torun_shell_commandFixes #2012