fix: sanitize control characters in terminal output#2007
Open
tengfeiwang1 wants to merge 2 commits intoQwenLM:mainfrom
Open
fix: sanitize control characters in terminal output#2007tengfeiwang1 wants to merge 2 commits intoQwenLM:mainfrom
tengfeiwang1 wants to merge 2 commits intoQwenLM:mainfrom
Conversation
- Add controlCharSanitizer utility to handle \r, \r\n, and other control chars - Apply sanitization at shellCommandProcessor, shell tool, and terminalSerializer - Prevents rendering issues in Ink-based UI caused by carriage returns - Add comprehensive unit tests (12 test cases) Fixes QwenLM#1950
This was referenced Feb 28, 2026
This was referenced Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1950 - Terminal output with
\r\nor standalone\rcauses interface misalignment in Ink-based UI.Problem
When tool output contains Windows-style line endings (
\r\n) or standalone carriage returns (\r), the terminal interface becomes misaligned because the carriage return moves the cursor to the beginning of the line without advancing, causing subsequent content to overwrite previous content.Solution
Following Claude Code's approach to terminal output handling, this PR adds a sanitization layer that:
\r\nto\n(Windows line endings)\rto\n(progress bar scenarios)Files Changed
packages/core/src/utils/controlCharSanitizer.ts- Core sanitization utilitypackages/core/src/utils/controlCharSanitizer.test.ts- 12 unit testspackages/core/src/tools/shell.ts- Apply sanitization at tool layerpackages/cli/src/ui/hooks/shellCommandProcessor.ts- Apply sanitization for real-time outputpackages/core/src/utils/terminalSerializer.ts- Apply sanitization at serialization layerTesting
controlCharSanitizershell.test.tsChecklist