Skip to content

Improve reactions to missing PCI devices#440

Merged
marmarek merged 1 commit into
QubesOS:mainfrom
marmarta:bugfix10409
May 28, 2026
Merged

Improve reactions to missing PCI devices#440
marmarek merged 1 commit into
QubesOS:mainfrom
marmarta:bugfix10409

Conversation

@marmarta
Copy link
Copy Markdown
Member

@marmarta marmarta commented Dec 9, 2025

Fix tests so that now they will fail if there is a bad reaction to an unknown PCI device. Clean-up handling unknown PCI devices by settigs.

requires QubesOS/qubes-core-admin-client#400
fixes QubesOS/qubes-issues#10409

Fix tests so that now they will fail if there is a bad reaction
to an unknown PCI device. Clean-up handling unknown PCI
devices by settigs.

requires QubesOS/qubes-core-admin-client#400
fixes QubesOS/qubes-issues#10409
@marmarek
Copy link
Copy Markdown
Member

marmarek commented Feb 7, 2026

PipelineRetry

@marmarta
Copy link
Copy Markdown
Member Author

This can't work without the linked PR in core-admin-client, and that one requires more work.

@qubesos-bot
Copy link
Copy Markdown

qubesos-bot commented May 4, 2026

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026052723-devel&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update

Failed tests

No failures!

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/176874#dependencies
Nothing fixed

Unstable tests

Details
  • system_tests_gui_tools

    desktop_linux_manager_config/ (1/5 times with errors)
    desktop_linux_manager_config/Failed (1/5 times with errors)
    • job 178840 # Test died: no candidate needle with tag(s) 'qubes-global-config' ...

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

No remaining performance tests

@marmarek
Copy link
Copy Markdown
Member

PipelineRetry

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.26%. Comparing base (70bcb5d) to head (62047e5).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   69.74%   72.26%   +2.52%     
==========================================
  Files          17       17              
  Lines        3989     4749     +760     
==========================================
+ Hits         2782     3432     +650     
- Misses       1207     1317     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marmarek marmarek merged commit efff1ef into QubesOS:main May 28, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Qube Manager crashes when attempting to view settings for a qube containing PCI devices that no longer exist

3 participants