Add prohibit-start to Qube Settings GUI.#414
Conversation
f3d7fe6 to
7cd4d32
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
==========================================
+ Coverage 68.80% 68.90% +0.10%
==========================================
Files 17 17
Lines 3808 3827 +19
==========================================
+ Hits 2620 2637 +17
- Misses 1188 1190 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031903-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update
Failed tests15 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/129058#dependencies 12 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:30 performance degradations
Remaining performance tests:42 tests
|
|
This behaves funny regarding empty value. First, when enabling the checkbox but not entering anything, the error message is "Error while saving changes: Feature not set for domain sys-whonix: prohibit-start". It isn't exactly clear that it's about empty value. |
Yes. I believe that I have to make it better. I believe once the rationale TextEntry box is shown, it should remain visible regardless of the status of the checkbox. And the logic has to be improved as well. |
|
Hiding it when checkbox gets unchecked is probably okay too (and probably should keep the value until dialog is closed). It the checkbox shouldn't automatically uncheck when rationale is cleared... |
marmarta
left a comment
There was a problem hiding this comment.
So, on testing, I think there is a bit of UX roughness here: namely, a user can click prohibit start and forget to provide reason, plus, the reason entry box is a bit awkward. My proposal:
- provide a default reason
- move the text box next to the checkbox, to avoid moving things around when the checkbox is clicked
- if the text box is empty and visible, it should scream in some way - maybe a red border? - and ok/apply probably shouldn't be clickable
7cd4d32 to
c0cde7a
Compare
prohibit_start.mp4 |
c0cde7a to
24361a9
Compare
No description provided.