Remove duplicate buttons using xfconf-query#256
Conversation
In the gnome-based template, xsettingsd was used to remove duplicate buttons. However, since xfce-based templates use xfsettingsd, xfconf-query is called at session startup to perform the same configuration.
| Version=1.0 | ||
| Encoding=UTF-8 | ||
| Name=xfconf-query for Xfce-based QubesVM | ||
| Exec=/usr/bin/xfconf-query --channel xsettings --property /Gtk/DecorationLayout --set "" |
There was a problem hiding this comment.
This is assuming that the qube:
- has
xfconf-query - is currently using Xfce
Both conditions need to be met for this script to be called.
First, can be done with TryExec=/usr/bin/xfconf-query. Also, I'd rather the path was not hardcoded.
Second, XDG_SESSION_DESKTOP=X-QUBES is present on fedora-43-minimal, which is not the Xfce flavor and doesn't have xfconf-query. So you will need to find another thing to query.
There was a problem hiding this comment.
Thank you for your review.
Since this won't take effect unless the qubes-gui-agent-xfce is installed, I think it's reasonable to assume that xfconf-query exists. That’s why I didn’t use TryExec=, but I wonder if I’m missing something.
Also, I'd rather the path was not hardcoded.
agree.
Since minimal template is intended for advanced users, I hadn't considered it.
I expect the same thing is possible by adding xsettingsd to the qubes-gui-agent package dependencies and placing the configuration file in its proper location, but I’m hesitant to add anything by default to minimal template, which is for advanced users who prefer minimizing things…
There was a problem hiding this comment.
Since minimal template is intended for advanced users, I hadn't considered it.
For advanced users to configure, doesn't mean things should be broken. I don't know if this breaks systemd somehow if it is configured to handle xdg autostart. But I'd rather that it is not left in a failed state, but skipped.
I expect the same thing is possible by adding
xsettingsdto thequbes-gui-agentpackage dependencies and placing the configuration file in its proper location, but I’m hesitant to add anything by default to minimal template, which is for advanced users who prefer minimizing things…
No need to add the package. It doesn't guarantee that xfce is currently running. Please find a way to know if Xfce is currently running and add that as a check to TryExec=.
There was a problem hiding this comment.
Since minimal template is intended for advanced users, I hadn't considered it.
For advanced users to configure, doesn't mean things should be broken.
To explain this better, minimal templates don't have everything working by default, I just don't want a failed state by default.
There was a problem hiding this comment.
No need to add the package. It doesn't guarantee that xfce is currently running. Please find a way to know if Xfce is currently running and add that as a check to TryExec=.
Is it really needed to check whether Xfce is currently running here?
All environment variables recommended for checking whether XFCE (DE) is currently running are override by 60xfce-desktop included in the qubes-gui-agent-xfce package, so as I see it, if the package is installed, Xfce is assumed to be running. Furthermore,xfconf-query does not fail even if Xfce is not running. But, --set alone will fail if the channel or property does not exist, so adding --create is planned.`)
TryExec=xfconf-query
Exec=xfconf-query --channel xsettings --property /Gtk/DecorationLayout --create --type string --set ""
With this change, it should no longer default to a failed state. (for example, even in a unique environment where only xfconf and qubes-gui-agent-xfce packages are installed on minimal template)
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026053102-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests56 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 21 fixed
Unstable testsDetails
Performance TestsPerformance degradation:26 performance degradations
Remaining performance tests:85 tests
|
4 participants
This will remove duplicate close buttons and others from affected
applications such as gedit in Xfce-based Debian/Fedora templates.
At first, I tried adding it to
60xfce-desktop.sh, but it had no effect.