updater: use qubes-vm-update to update dom0 non-interactively

[piotrbartman]

GUI updater shows dom0 update progress

for test requires: QubesOS/qubes-core-admin-client/pull/404
requires: QubesOS/qubes-core-admin-linux/pull/191

[codecov]

Codecov Report

❌ Patch coverage is 93.61702% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.71%. Comparing base (1f295d9) to head (92ba90e).
⚠️ Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
qui/updater/intro_page.py	84.84%	5 Missing ⚠️
qui/updater/progress_page.py	60.00%	4 Missing ⚠️
qui/updater/utils.py	89.28%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   92.63%   92.71%   +0.08%     
==========================================
  Files          66       66              
  Lines       13672    13618      -54     
==========================================
- Hits        12665    12626      -39     
+ Misses       1007      992      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[marmarta]

I might be confused here, but I think the check for skip-update is needed?

[piotrbartman]

It's in lines 123–126 (dom0 is now treated like the other VMs).

[marmarek]

This has conflicts now...

[qubesos-bot]

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026051515-devel&flavor=pull-requests

Test run included the following:

• DONOTMERGE - Enable qmemman debug log qubes-core-admin#783 (QubesOS/qubes-core-admin@d986e13)
• updater: use qubes-vm-update to update dom0 non-interactively #264 (92ba90e)

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update

Failed tests

No failures!

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/176874#dependencies
Nothing fixed

Unstable tests

Details

• system_tests_gui_tools

  desktop_linux_manager_config/ (4/5 times with errors)

  • job 178818 None
  • job 178835 None
  • job 178837 None
  • job 178840 None
  desktop_linux_manager_config/Failed (4/5 times with errors)

  • job 178818 # Test died: no candidate needle with tag(s) 'qubes-global-config' ...
  • job 178835 # Test died: no candidate needle with tag(s) 'qubes-global-config' ...
  • job 178837 # Test died: no candidate needle with tag(s) 'qubes-global-config' ...
  • job 178840 # Test died: no candidate needle with tag(s) 'qubes-global-config' ...
  desktop_linux_manager_config/wait_serial (1/5 times with errors)

  • job 178837 # Command: curl --form upload=@/var/log/libvirt/libxl/libxl-driver....

• system_tests_gui_tools@hw7

  desktop_linux_manager_config/ (4/5 times with errors)

  • job 178818 None
  • job 178835 None
  • job 178837 None
  • job 178840 None
  desktop_linux_manager_config/Failed (4/5 times with errors)

  • job 178818 # Test died: no candidate needle with tag(s) 'qubes-global-config' ...
  • job 178835 # Test died: no candidate needle with tag(s) 'qubes-global-config' ...
  • job 178837 # Test died: no candidate needle with tag(s) 'qubes-global-config' ...
  • job 178840 # Test died: no candidate needle with tag(s) 'qubes-global-config' ...
  desktop_linux_manager_config/wait_serial (1/5 times with errors)

  • job 178837 # Command: curl --form upload=@/var/log/libvirt/libxl/libxl-driver....

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

No remaining performance tests

[marmarek]

opening updater from the widget failed with:

Jun 23 10:25:51.247349 dom0 qui-updates[3269]: gdk_window_thaw_toplevel_updates: assertion 'window->update_and_descendants_freeze_count > 0' failed

I'm not sure if it's related to this PR, I'll restart the test..

[marmarek]

This needs a rebase (hopefully last one).