sys-log: log filter#634
Conversation
|
Check CI: https://gitlab.com/QubesOS/qubes-core-agent-linux/-/jobs/13418710566 |
|
rn, CI is running with an old version of qubes-pure (see description) |
|
PipelineRetry |
|
There is new linux-utils now, but it still fails to build in CI |
| } | ||
|
|
||
|
|
||
| backend->write(trusted_prio, trusted_msg); |
There was a problem hiding this comment.
This (and other references to backend) was introduced in the "sys-log: reformat whitespaces" commit. Please don't put functional changes in such commit...
| @@ -0,0 +1,2 @@ | |||
| #!/bin/sh | |||
| exec /usr/lib/qubes/vm-log No newline at end of file | |||
There was a problem hiding this comment.
You can simply install qubes.Log as a symlink to /usr/lib/qubes/vm-log - avoids extra shell call.
piotrbartman
force-pushed
the
sys-log/alpha
branch
from
e6e99e4 to
1155c81
Compare
avoid extra shell call
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
+ Coverage 70.30% 71.71% +1.41%
==========================================
Files 3 3
Lines 495 502 +7
==========================================
+ Hits 348 360 +12
+ Misses 147 142 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Anything missing here? In other words: is it intentionally "draft"? |
Now, through `qvm-features sys-log vm-config.log-backend`, we can control where logs go. This allows users to perform additional post-processing of logs.
|
As a basic version, this PR was done, but I wanted to develop the idea of a log-backend controlled by qvm-features. |
|
PipelineRetry |
| return 0; | ||
| } | ||
|
|
||
| FILE *fp = popen("qubesdb-read /vm-config/log-backend 2>/dev/null", "r"); |
There was a problem hiding this comment.
Use qubesdb library instead? Example use: https://github.com/QubesOS/qubes-gui-agent-linux/blob/main/pulse/module-vchan-sink.c#L665-L685
3 participants
A simple and efficient log sanitizer, ready to work with rsyslog
first step in: QubesOS/qubes-issues/issues/830
requires: QubesOS/qubes-linux-utils/pull/136