Skip to content

replace random with secrets #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marmarek merged 1 commit into from
Apr 23, 2026
+4 −4
Merged

replace random with secrets #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions qubes/storage/zfs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import dataclasses
import logging
import os
import random
import secrets
import shlex
import shutil
import string
Expand Down Expand Up @@ -81,7 +81,7 @@ def get_random_string(
length: int,
character_set: str = string.ascii_lowercase,
) -> str:
return "".join(random.choice(character_set) for _ in range(length))
return "".join(secrets.choice(character_set) for _ in range(length))


T = TypeVar("T")
Expand Down
4 changes: 2 additions & 2 deletions qubes/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
import asyncio
import hashlib
import logging
import random
import re
import secrets
import string
import os
import os.path
Expand Down Expand Up @@ -186,7 +186,7 @@ def get_entry_point_one(group, name):
def random_string(length=5):
"""Return random string consisting of ascii_leters and digits"""
return "".join(
random.choice(string.ascii_letters + string.digits)
secrets.choice(string.ascii_letters + string.digits)
for _ in range(length)
)

Expand Down