Fix preload autostart integration test#706
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #706 +/- ##
==========================================
- Coverage 70.53% 70.47% -0.06%
==========================================
Files 61 61
Lines 13546 13546
==========================================
- Hits 9554 9546 -8
- Misses 3992 4000 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025072404-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update
Failed tests18 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/142375#dependencies 8 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:7 performance degradations
Remaining performance tests:65 tests
|
| self.assertEqual(len(old_preload), preload_max) | ||
| self.assertEqual(len(preload_dispvm), preload_max) | ||
| self.assertTrue( | ||
| set(old_preload).isdisjoint(preload_dispvm), |
There was a problem hiding this comment.
Why is it supposed to be disjoint? I don't see anything using or killing preloaded between collecging old_preload and preload_dispvm? You just unset the feature on the disposable template, but it's still set via global property at that time, so it shouldn't matter, no?
There was a problem hiding this comment.
This unsets the feature:
proc = self.loop.run_until_complete(
asyncio.create_subprocess_exec("/usr/lib/qubes/preload-dispvm")
)
In other words, event domain-preload-dispvm-autostart does it.
There was a problem hiding this comment.
Ok, this could use a comment then, next to calling that script here.
There was a problem hiding this comment.
I added as a doctstring because there is another disjoint on the block before and I prefer to consider both blocks with a single comment.
ben-grande
force-pushed
the
preload-integ-fix
branch
from
41282af to
7c3a5bc
Compare
3 participants
For: #700
For: QubesOS/qubes-issues#1512