Skip to content

Set last dimension to 0 for fusiontensor of forbidden fusions#91

Merged
lkdvos merged 2 commits into
mainfrom
fix-fusiontensor
May 7, 2026
Merged

Set last dimension to 0 for fusiontensor of forbidden fusions#91
lkdvos merged 2 commits into
mainfrom
fix-fusiontensor

Conversation

@Yue-Zhengyuan

Copy link
Copy Markdown
Member

This PR fixes fusiontensor(a, b, c) by always setting the last dimension (degeneracy) to 0 if the fusion a ⊗ b → c is forbidden (i.e. Nsymbol(a, b, c) = 0).

Closes #90.

@Yue-Zhengyuan

Copy link
Copy Markdown
Member Author

BTW, what is NewSU2Irrep for? What can it do that cannot be done with SU2Irrep?

@lkdvos

lkdvos commented May 7, 2026

Copy link
Copy Markdown
Member

The NewSU2Irrep is only there for testing purposes, to verify the minimal interface. Probably this is no longer really all that useful

@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/fermions.jl 84.09% <100.00%> (+0.36%) ⬆️
src/irreps/cu1irrep.jl 96.50% <100.00%> (+0.02%) ⬆️
src/irreps/dnirrep.jl 97.85% <100.00%> (+0.01%) ⬆️
src/irreps/irreps.jl 97.14% <100.00%> (+0.08%) ⬆️
src/irreps/su2irrep.jl 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yue-Zhengyuan

Copy link
Copy Markdown
Member Author

@lkdvos There is an SU(3) test error out of my control.

@lkdvos

lkdvos commented May 7, 2026

Copy link
Copy Markdown
Member

That should be unrelated, I'll merge this once all tests finish :)

@lkdvos lkdvos merged commit a90386c into main May 7, 2026
11 of 12 checks passed
@lkdvos lkdvos deleted the fix-fusiontensor branch May 7, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dimension of last index of fusiontensor

2 participants