Fix segmentation fault and bump TBLIS_jll version#20
Open
liuzhaochen wants to merge 5 commits into
Open
Conversation
Fix mising "$" symbol
- Using newest version of TBLIS_jll
Root cause: tblis_tensor constructor created local dims/strides vectors,
passed their data pointers to the C struct's len/stride fields, then let
them go out of scope. TBLIS dereferenced freed memory on subsequent calls.
Fix: introduce TblisTensor{T} wrapper that holds the C struct, dims/strides
vectors, and parent array reference, keeping all pointed-to memory alive.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a wrapper that keeps the metadata and parent array alive for the lifetime of a foreign array view.
Without this wrapper,
tblis_tensor_multmay trigger a segmentation fault due to dangling pointers.This PR also bumps the
TBLIS_jllversion.