Skip to content

Add some basic support for svd_trunc_no_error#390

Open
kshyatt wants to merge 2 commits into
mainfrom
ksh/svd_no_error
Open

Add some basic support for svd_trunc_no_error#390
kshyatt wants to merge 2 commits into
mainfrom
ksh/svd_no_error

Conversation

@kshyatt

@kshyatt kshyatt commented Jun 1, 2026

Copy link
Copy Markdown
Member

My goal here is to start allowing users to set in the algorithm whether or not they want the truncation error computed. The benefit of not computing it is increased speed and possibly some AD benefits. For now I've done the easiest part -- hooking up svd_trunc_no_error, adding ChainRules.jl pullback support, and adding tests. Next is to figure out a nice way to control when to use it in the actual CTMRG functions themselves.

@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/utility/svd.jl 0.00% 63 Missing ⚠️
Files with missing lines Coverage Δ
src/utility/svd.jl 8.86% <0.00%> (-43.19%) ⬇️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Your PR no longer requires formatting changes. Thank you for your contribution!

@kshyatt kshyatt requested a review from pbrehmer June 5, 2026 08:29

@pbrehmer pbrehmer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! I'm curious though, is there a specific use case that we had in mind where we need this SVD without computing the truncation error? I guess you already mentioned increased performance so that's already a good reason :-)

@kshyatt

kshyatt commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

It might be nice to not have to calculate it every time for the GPUified PEPS as computing the error is actually surprisingly expensive.

@kshyatt kshyatt force-pushed the ksh/svd_no_error branch from 0f4bea3 to 752c439 Compare June 10, 2026 16:02
@kshyatt kshyatt marked this pull request as ready for review June 10, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants