Fix dimension mismatches in SVD pullback due to rank_atol#357
Closed
pbrehmer wants to merge 3 commits into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Member
|
Will close this since it should be fixed by QuantumKitHub/MatrixAlgebraKit.jl#208 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #351, there was the possibility for a
DimensionMismatcherror due to the non-zero defaultrank_atolin MatrixAlgebraKit's SVD pullbacks. Here I setrank_atol=0explicitly forFixedSVDandIterSVDpullbacks, so that error shouldn't happen again.I'm not quite sure how to test this, so if anybody has an idea, let me know.