Conversation
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/operators/abstractmpo.jl b/src/operators/abstractmpo.jl
index d5b0295..d86c48c 100644
--- a/src/operators/abstractmpo.jl
+++ b/src/operators/abstractmpo.jl
@@ -153,7 +153,7 @@ Compute the mpo tensor that arises from multiplying MPOs.
"""
function fuse_mul_mpo(O1, O2)
TT = promote_type(scalartype(O1), scalartype(O2))
- T = TensorKit.promote_storagetype(TT, O1, O2)
+ T = TensorKit.promote_storagetype(TT, O1, O2)
F_left = fuser(T, left_virtualspace(O2), left_virtualspace(O1))
F_right = fuser(T, right_virtualspace(O2), right_virtualspace(O1))
return _fuse_mpo_mpo(O1, O2, F_left, F_right) |
|
Fake news: it's due to git eating part of the changes to |
Codecov Report❌ Patch coverage is
... and 59 files with indirect coverage changes 🚀 New features to boost your workflow:
|
| function VectorInterface.scale(mpo::AbstractMPO, α::Number) | ||
| T = VectorInterface.promote_scale(scalartype(mpo), scalartype(α)) | ||
| dst = similar(mpo, T) | ||
| dst = similar(mpo, TensorKit.similarstoragetype(storagetype(mpo), T)) |
There was a problem hiding this comment.
It might be better to update similar(mpo, ::Type{<:Number}) to do exactly this, so we automatically have this behavior everywhere similar is used?
| TE = TensorKit.similarstoragetype(TensorKit.storagetype(W), E) | ||
| W′ = similar(W, TE) |
There was a problem hiding this comment.
similar comment here, would it make sense to use similar(W, E) and implement the similar to do the storagetype conversion?
2 participants
Revealed a bunch more missing things needing fixes, so I will keep this as draft for now.