docs: factory upgrade build plan (design → build → deploy)#36
Open
cryptoxdog wants to merge 1 commit into
Open
docs: factory upgrade build plan (design → build → deploy)#36cryptoxdog wants to merge 1 commit into
cryptoxdog wants to merge 1 commit into
Conversation
Adds docs/factory-upgrade-build-plan.md — the granular, execution-ready phased plan (P-A → P-F) to turn the factory from its current hollow state (generated content dies in an in-memory map; no Astro site is materialized; deploy rebuilds an empty repo) into a working design → build → deploy factory that SEO-Bot then maintains. Covers architecture decisions, the 12-stage order, BuildContext additions, the SiteAssembler render algorithm, per-phase files/verification, and an end-to-end test. TODO.md "Build the core factory capability" section now flags this doc as the plan of record. Docs-only; no code changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VqWfuXWTn5jo8f5fnkSozx
|
There was a problem hiding this comment.
Pull request overview
Adds an execution-ready, phased roadmap to implement the missing “materialize + build + per-client deploy” parts of the Website Factory, and links that plan from TODO.md as the plan of record.
Changes:
- Adds
docs/factory-upgrade-build-plan.md, detailing phases P‑A → P‑F, architecture decisions, stage ordering, and verification steps. - Updates
TODO.mdto reference the new doc from the “Build the core factory capability” section.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| TODO.md | Links the new phased factory upgrade plan as the authoritative reference. |
| docs/factory-upgrade-build-plan.md | Introduces the detailed phased build plan (design → build → deploy) and proposed architecture/stage changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+148
to
+152
| - `Website-Bot/src/pipeline/BuildContext.ts` — add `outputDir`, `designTokens`, `siteConfig`, `distDir`, `deployTarget`. | ||
| - `Website-Bot/scripts/run-pipeline.ts` — register `SiteAssembler` + `SiteBuild`, reorder, set `outputDir`. | ||
| - `Website-Bot/src/stages/DesignIntelligenceStage.ts`, `PostHogSnippetStage.ts` — write to ctx/outputDir, fix layout target. | ||
| - `Website-Bot/src/stages/VercelDeployStage.ts` — per-client repo push + project deploy. | ||
| - `Website-Bot/src/stages/HandoffEmitterStage.ts` — emit `site_deployment`. |
| - `Website-Bot/src/stages/VercelDeployStage.ts` — per-client repo push + project deploy. | ||
| - `Website-Bot/src/stages/HandoffEmitterStage.ts` — emit `site_deployment`. | ||
| - `SEO-Bot/src/api/clients/register.ts` + `SEO-Bot/src/contracts/website_factory_v2.ts` — persist `site_deployment`. | ||
| - New: `Website-Bot/astro_template/` (P-A); `Website-Bot/src/stages/SiteAssemblerStage.ts`, `SiteBuildStage.ts`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the execution-ready phased plan for building out the factory's core capability, and references it from
TODO.md.What
docs/factory-upgrade-build-plan.md— the granular upgrade build plan (phases P-A → P-F): extract a client-neutralastro_template/→ newSiteAssemblerStage(the missing "materialize" step that consumesctx.generatedContent) → localastro buildgate → per-client Vercel/repo deploy → persistsite_deploymenton SEO-Bot registration → per-client provisioning. Includes architecture decisions (one-repo-per-client, push-source-then-deploy, data-driven section rendering, dir-per-route paths), the final 12-stage order,BuildContextadditions, the assembler render algorithm, per-phase files + verification, risks/sequencing, and an end-to-end test.TODO.md— the "Build the core factory capability" section now flags this doc as the plan of record.Why
The audit in this doc's Context shows the factory's generate→build→deploy spine is currently hollow — generated content dies in an in-memory map, no Astro site is ever materialized, and deploy rebuilds an empty repo. This plan is the roadmap to make it a real factory.
Docs-only — no code changes. This is the plan; implementation follows per-phase after review.
🤖 Generated with Claude Code
Generated by Claude Code