feat(hygiene 2/5): Graphiti context-memory sink (supersedes PR #2)#7
Merged
Conversation
added 2 commits
July 5, 2026 04:15
Patches context-memory to feed Graphiti episodes via graphiti_sink.py and adds show_context_graphiti.py for querying the graph directly. JSON session storage kept as local cache; Graphiti becomes the durable substrate. - add intelligence/context-memory/graphiti_sink.py (emit_session to graph) - add intelligence/context-memory/show_context_graphiti.py (query graph context)
…ck, defensive key access, UTF-8 encoding, stderr surfacing Fixes: - Use sys.executable instead of hard-coded 'python' (interpreter consistency) - Check proc.returncode before parsing stdout (silent failure prevention) - Defensive .get() on fact items instead of f['fact'] (KeyError prevention) - Explicit encoding='utf-8' on JSON cache write (cross-platform determinism) - Surface stderr in return dict when MCP call fails (debuggability) - Proper fallback messaging when graph is empty or unavailable
SonarCloud pythonsecurity:S8705 flagged unvalidated CLI input (task_type, ultimately from sys.argv[1]) flowing into a subprocess.run argument list. No shell=True is used so this isn't a classic shell-injection, but add defense-in-depth validation (type/length/control-char checks) before the value reaches the OS command, per the gate's requirement.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Collaborator
Author
|
Remediation pass:
|
SonarCloud pythonsecurity:S8705 still flagged line 43 (subprocess.run) after the prior fix -- the denylist-based _validate_task_type() helper sanitizes correctly at runtime, but SAST taint tracking generally only recognizes sanitization it can see directly at/near the sink, not arbitrary custom functions across a call boundary. Replaced with an inline allow-list regex (fullmatch) checked directly in restore() immediately before the subprocess.run() call -- the pattern taint-tracking tools reliably recognize as clearing tainted input. Same security properties (rejects control/null bytes, empty input, oversized input, and now also non-allow-listed punctuation), same 500-char cap. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
Follow-up fix (cd3bebd): SonarCloud's Quality Gate still failed after the prior fix ( |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of 5 — scoped split of the Cursor-Governance Hygiene Commit Pack.
What
Adds
intelligence/context-memory/graphiti_sink.py+show_context_graphiti.py(Graphiti episode emitter + graph context viewer), plus the review-comment fixes (sys.executable, returncode check, defensive key access, UTF-8, stderr surfacing).Collision resolution — supersedes PR #2
This is the content of open PR #2 with the review fixes folded in. PR #2 should be closed as superseded by this PR (do not merge both — same files). A superseded comment has been posted on PR #2.
Split context
1 of 5 independent, disjoint PRs — any merge order. Applies cleanly on
main(git amverified);graphiti_sink.pycompiles.🤖 Generated with Claude Code
https://claude.ai/code/session_01Rr6wpk9eehnJdRmh5BwWGG
Generated by Claude Code