fix: Bypass deprecated feature_dtypes_ setter in fit() - #1013
Merged
Conversation
Assign directly to _feature_dtypes_ to avoid triggering the deprecation warning on every fit() call when X is a DataFrame.
Jan Tilly (jtilly)
requested review from
Marc-Antoine Schmidt (MarcAntoineSchmidtQC) and
Martin Stancsics (stanmart)
as code owners
July 8, 2026 18:57
The getter is triggered by sklearn's __dir__ override, which calls hasattr() on every attribute of every fitted estimator. Keeping the deprecation warning on the getter floods users with warnings they cannot act on. The setter deprecation is retained to discourage external writes to feature_dtypes_.
Marc-Antoine Schmidt (MarcAntoineSchmidtQC)
approved these changes
Jul 9, 2026
Marc-Antoine Schmidt (MarcAntoineSchmidtQC)
merged commit Jul 9, 2026
ca84caa
into
main
26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes:
_feature_dtypes_instead of going through the deprecatedfeature_dtypes_setter, eliminating theDeprecationWarningemitted on everyfit()call whenXis a DataFrame.feature_dtypes_getter, because that's also firing for things such asdir(...)and other introspection calls.