Repository navigation
ci: Use federated Google credentials for Schwab refresh - #109
Merged
Merged
Conversation
Pigbibi
added
risk:high
Pigbibi
marked this pull request as ready for review
November 9, 2026 20:13
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Pigbibi
added
the
agent-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Codex assisted with implementation and validation.
What changed
The scheduled and manual refresh job uses short-lived Google credentials from GitHub OIDC. Refresh is restricted to the default branch. Broker authentication, the destination and version retention are unchanged. The application still accepts legacy credentials from independent local callers.
How verified
Why
Remove the scheduled job's need for a long-lived Google service account key.
Risk
High. This changes credential acquisition for a scheduled broker-token refresh. The dedicated federation provider and GitHub variables have been configured and read back. The service account has no user-managed key or project-level role. It has add, list and destroy permissions only on the existing destination secret, and trusts the refresh workflow on the default branch for scheduled and manual events. Keep the old credential available for rollback until a successful natural refresh.