Skip to content

ci(governance): adopt the shared PR governance action - #106

Merged
Pigbibi merged 2 commits into
mainfrom
chore/governance-action-v2
Nov 7, 2026
Merged

Pigbibi merged 2 commits into
mainfrom
chore/governance-action-v2

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

AI assistance

Qoder agent (Claude) performed the migration and the checks below.

What changed

Replace the inline gate with the organization's shared QuantStrategyLab/.github/pr-governance action, pinned to 91252f55364c2e1f555cc42111a1897b47ce52fd (tag v3):

  • .github/workflows/risk-gate.yml is now the rendered shared template; it reads the reviewer identity from RISK_GATE_REVIEWER_APP_ID, RISK_GATE_REVIEWER_USER_ID and RISK_GATE_REVIEWER_LOGIN.
  • .github/governance/policy.json holds the repo policy without account identifiers, per the content-boundary rule in AGENTS.md.
  • .github/workflows/pr-review-signal.yml relays fork review events to the trusted run.

The gate still validates app id, user id and login before trusting a receipt; a partial configuration fails closed.

How verified

  • The rendered gate differs from the shared template only by the repo name and the pinned SHA.
  • The reviewer variables are set on the repository; the owner variables come from the organization.
  • Classification stays at least as strict: every .github/** path, manifests, and credential/runtime/strategy paths are R2; prose in docs/ and README is R0.

Replace the inline gate with the pinned v2 composite action, move the
repo policy into .github/governance/policy.json, and relay fork review
events through the permissionless signal workflow. Status check
contexts are unchanged: risk-gate, ai-review, pr-template, clearing-label.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T14:32:57.271499Z ccd4001 Manual request
🔒 Security Review ✅ Completed 2026-11-07T14:35:04.652085Z ccd4001 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa4a6adead

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/governance/policy.json Resolved
The repository content rules forbid account identifiers in public source, so
the policy no longer carries them and the gate reads RISK_GATE_REVIEWER_APP_ID,
RISK_GATE_REVIEWER_USER_ID and RISK_GATE_REVIEWER_LOGIN. The action is pinned
to v3, which resolves and validates that configuration before trusting a receipt.
@Pigbibi

Pigbibi commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: ccd4001494

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: ccd4001494

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 7, 2026
@Pigbibi
Pigbibi merged commit d45dd0e into main Nov 7, 2026
17 of 19 checks passed
@Pigbibi
Pigbibi deleted the chore/governance-action-v2 branch November 7, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant