Repository navigation
fix(digest): Bind IBKR account display to the Telegram recipient - #1120
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Pigbibi
added
risk:high
Pigbibi
marked this pull request as ready for review
November 12, 2026 06:11
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Pigbibi
added
the
agent-approved
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Codex. Independent review is requested through the repository integration.
What changed
Bind full IBKR broker IDs to the existing approved Azure scheduled Telegram recipient and the exact digest slots. Keep the private account mapping outside the digest roster, previews and delivery receipts.
Add a private roster projection and drift check that follow management platform order, remove IBKR aliases and reject changed enrollment identities. Strategy labels still come from each existing strategy profile.
How verified
72 focused unit tests passed, including recipient and target mismatch, alternate triggers, preview redaction, receipt redaction, account order and changed selector rejection. The staged secret scan and whitespace check passed.
Why
IBKR instance labels can describe strategies. The account field needs the verified broker identity even if an instance or strategy is renamed.
Risk
The change is limited to the account text of the existing approved Telegram digest. Activation requires a recipient-bound setting in the protected Azure job. Account data sources, deduplication, schedules and order paths are unaffected.