Skip to content

feat: Read verified Binance holdings in the daily digest - #1112

Merged
Pigbibi merged 2 commits into
mainfrom
feat/binance-readonly-daily-holdings
Nov 11, 2026
Merged

Pigbibi merged 2 commits into
mainfrom
feat/binance-readonly-daily-holdings

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

AI assistance

OpenAI Codex

What changed

  • Add a read-only console endpoint for the latest bound Binance Spot and Flexible Earn snapshot in the requested closed Singapore business day.
  • Admit one optional Binance snapshot source to the scheduled digest and verify its account, target and observation time before rendering holdings.
  • Report trading activity, submissions and fills as unknown when the source is only a snapshot. A missing source credential affects only the Binance section.

How verified

  • The focused scheduled digest tests passed, including wrong account, wrong window, redirect rejection and isolation from other accounts.
  • The Worker account-facts suite passed, including token isolation, closed-window selection and a check that reads do not publish observations.
  • The staged secret scan and whitespace check passed.

Why

The existing read-only Binance account snapshot is published independently of trading. The scheduled digest needs a limited way to reuse it while preserving the difference between holdings and execution evidence.

Refs QuantStrategyLab/.github#36 and QuantStrategyLab/.github#40.

Risk

R2 for the protected digest and Worker paths. The optional source is disabled until its account binding and dedicated read credential are installed. No existing credentials or trade settings are changed by this source patch.

Co-Authored-By: Codex <noreply@openai.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T08:41:35.578194Z 3535230 New commits
🔒 Security Review ✅ Completed 2026-11-11T08:47:40.107417Z 3535230 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c2f3b59ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/strategy-switch-console/worker.js Resolved
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 11, 2026
@Pigbibi
Pigbibi merged commit 2b1f58d into main Nov 11, 2026
21 of 22 checks passed
@Pigbibi
Pigbibi deleted the feat/binance-readonly-daily-holdings branch November 11, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant