Skip to content

fix: Preserve verified daily account observations - #1111

Merged
Pigbibi merged 2 commits into
mainfrom
fix/digest-account-evidence
Nov 11, 2026
Merged

Pigbibi merged 2 commits into
mainfrom
fix/digest-account-evidence

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

AI assistance

OpenAI Codex

What changed

  • Preserve the highest verified order or fill count as an observed minimum when runs may overlap.
  • Keep the most recent verified assets and holdings with the observation time for each field.
  • Show the verified reason for an approved risk block and require evidence of an order before describing its final status as unconfirmed.

How verified

  • Reproduced all four regressions through the authenticated caller with synthetic protected candidates.
  • The 23 focused tests pass in the checkout and with the updated renderer applied to the current package layout.
  • The repository documentation check, staged Gitleaks scan and whitespace check passed.

Why

The scheduled account report could display unknown counts despite verified activity, hide a verified balance behind a newer positions-only snapshot, or imply an order existed when only the run outcome was uncertain.

Refs QuantStrategyLab/.github#36 and QuantStrategyLab/.github#40.

Risk

R2 for the protected digest presentation path. The change uses the existing bound candidate schema and leaves scheduling, routing, account enrollment and trading controls unchanged.

Co-Authored-By: Codex <noreply@openai.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T07:26:15.241834Z c948ef7 New commits
🔒 Security Review ✅ Completed 2026-11-11T07:27:52.167273Z c948ef7 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Pigbibi Pigbibi added agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation and removed agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation labels Nov 11, 2026
…idence

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 11, 2026
@Pigbibi
Pigbibi merged commit e3a5b37 into main Nov 11, 2026
19 of 20 checks passed
@Pigbibi
Pigbibi deleted the fix/digest-account-evidence branch November 11, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant