Skip to content

fix: Show daily account coverage and distinct filled orders - #1109

Merged
Pigbibi merged 3 commits into
mainfrom
fix/daily-account-report-coverage
Nov 10, 2026
Merged

Pigbibi merged 3 commits into
mainfrom
fix/daily-account-report-coverage

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

AI assistance

OpenAI Codex

What changed

  • Show platforms without an approved source binding in the scheduled account report and describe the management console's role.
  • Separate submitted orders, fill reports and distinct orders with fills. Show an observed minimum when the complete execution inventory is unavailable.
  • Preserve reported legacy equity with its missing snapshot time identified. Display explicit persistence and delivery failures beside execution issues.

How verified

  • Full Python suite, with 1,178 tests run and 12 skipped. Focused Cloud Run and bilingual golden tests also passed after the final wording adjustment.
  • Repository documentation check, focused Ruff error checks and staged Gitleaks scan.

Why

The November account report omitted unbound platforms, did not distinguish fill reports from orders with fills, and concealed explicit evidence failures.

Refs QuantStrategyLab/.github#36 and QuantStrategyLab/.github#40.

Risk

R2 for the protected daily digest paths. The scope is account report presentation and its regression tests. Upstream account facts remain limited to available evidence.

Pigbibi and others added 2 commits November 11, 2026 05:13
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi marked this pull request as ready for review November 10, 2026 21:25
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T21:36:25.752047Z ea644eb Manual request
🔒 Security Review ✅ Completed 2026-11-10T21:39:04.111447Z ea644eb Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi

Pigbibi commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: ea644ebcd5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: ea644ebcd5

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 10, 2026
@Pigbibi
Pigbibi merged commit 2134030 into main Nov 10, 2026
20 of 22 checks passed
@Pigbibi
Pigbibi deleted the fix/daily-account-report-coverage branch November 10, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant