feat: Add the Desk delivery read contract by Pigbibi · Pull Request #1108 · QuantStrategyLab/QuantRuntimeSettings

Pigbibi · 2026-11-10T07:41:22Z

AI assistance

OpenAI Codex (GPT-6), verification continuation of the existing B2 candidate.

What changed

Add authenticated GET /api/desk/alerts/delivery through the existing notification-log read adapter. Extend the existing Desk response schema with optional read coverage and per-run/attempt/date sender facts. Preserve unknown receiver acknowledgement, channel health and last-delivery/digest values. No sender, store, UI or receipt window is changed.

Field mapping and compatibility: schemas/desk/README.md.

How verified

Full unchanged Python unit suite: 1174 tests, 12 skipped, zero failures/errors. The compatibility test uses a byte-identical private compat root to exclude unrelated host siblings. Original-path control reproduces the same three unchanged-HEAD assertions; private-root control passes all nine cases. No checker or test source was modified.
An initial full-suite attempt under noexec /dev/shm was invalid for executable fake tools and had an incorrect harness import path; retained as environment evidence. Corrected run uses an executable private temporary directory, standard repository imports and an inode reserve guard.
Desk schema/read contracts, console API contracts, actual Worker route and notification receipt/transport tests passed. Complete Desk/frontend operations, TypeScript/Vite build and size budgets passed.
Display/config generation, runtime target validation, documentation check and diff whitespace passed (one existing documentation advisory).
External adverse harness: redaction, malformed-source fail-closed and fresh-state tests fail against unchanged HEAD's absent route and pass against this candidate. Concurrency, restart and cross-run/attempt/window cases pass in the candidate tests.
Local Python 3.13 and Node 24; hosted Python 3.12/Node 22 checks and official review remain separate required gates.

Why

The Desk needs an honest sender-evidence read contract without inferring receiver acknowledgement or joining unrelated runs and reporting windows.

Risk

Read-only backend/schema change with Worker routing. No production deployment, pin, notification send, IAM/Secret or trading action. Publication workflow review found validation/review workflows only for this feature branch/PR; release and notification workflows require explicit manual dispatch (release additionally main-bound). Keep the PR Draft and all native required checks, including python, enforced. Runtime adoption remains unproved.

Publication check

publication-check/2.0-advisory, build 83d9d1130377: exit 0 (advisory), 4130 findings / 4127 matching lines across the complete tracked candidate plus explicit new files. Two findings are controlled fake-test syntax; other repository-wide findings are outside this bounded change. This advisory does not bypass native required checks. First 20 (masked text):

tests/desk_delivery_read_validation.mjs:46 "const project = <PROJECT_ID> => deskDelivery({}, { notificationReceipts: async () => source }, now);"
tests/desk_delivery_read_validation.mjs:90 "  as_of: \"2030-02-30T00:00:00Z\", secret: <REDACTED>"<REDACTED>\", items: [{"
.github/CODEOWNERS:4 "/.github/CODEOWNERS @<PROJECT_ID>"
.github/CODEOWNERS:5 "/.github/workflows/ @<PROJECT_ID>"
.github/CODEOWNERS:6 "/actions/publish-runtime-execution-evidence/ @<PROJECT_ID>"
.github/CODEOWNERS:7 "/python/scripts/check_credential_maintenance_read.py @<PROJECT_ID>"
.github/CODEOWNERS:8 "/python/scripts/credential_maintenance_notify.py @<PROJECT_ID>"
.github/CODEOWNERS:9 "/python/scripts/deployment_bundle_contract.py @<PROJECT_ID>"
.github/CODEOWNERS:10 "/python/scripts/deterministic_risk_gate.py @<PROJECT_ID>"
.github/CODEOWNERS:11 "/python/scripts/execution_evidence_projection.py @<PROJECT_ID>"
.github/CODEOWNERS:12 "/python/scripts/forward_observation_risk_control.py @<PROJECT_ID>"
.github/CODEOWNERS:13 "/python/scripts/long_horizon_risk_composer.py @<PROJECT_ID>"
.github/CODEOWNERS:14 "/python/scripts/long_horizon_risk_composer_v2.py @<PROJECT_ID>"
.github/CODEOWNERS:15 "/python/scripts/long_horizon_risk_observation_ingress.py @<PROJECT_ID>"
.github/CODEOWNERS:16 "/python/scripts/long_horizon_risk_observation_ingress_v2.py @<PROJECT_ID>"
.github/CODEOWNERS:17 "/python/scripts/paper_risk_admission_receipt.py @<PROJECT_ID>"
.github/CODEOWNERS:18 "/schemas/qsl-deployment-bundle.v1.schema.json @<PROJECT_ID>"
.github/CODEOWNERS:19 "/schemas/qsl-forward-observation-risk-control.v1.schema.json @<PROJECT_ID>"
.github/CODEOWNERS:20 "/schemas/qsl-reconcile-only-risk-control.v1.schema.json @<PROJECT_ID>"
.github/CODEOWNERS:21 "/scripts/provision_binance_recovery_credentials.sh @<PROJECT_ID>"}

Pigbibi · 2026-11-10T07:41:54Z

@codex review

Please review the current head 309a3163bfd2c34d813b044e7c83fd0e994309d1 for this bounded read-only Desk delivery contract. The complete local suite is green with host-sibling compatibility isolation; all native checks remain required. Keep this PR Draft. No merge or deployment is requested.

chatgpt-codex-connector · 2026-11-10T07:42:49Z

Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-10T09:13:34.251772Z	`15f8338`	Manual request
🔒 Security Review	✅ Completed 2026-11-10T09:15:52.712359Z	`15f8338`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector · 2026-11-10T07:44:21Z

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 309a3163bf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-11-10T07:47:50Z

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 309a3163bf

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Pigbibi · 2026-11-10T09:11:46Z

@codex review

Please review the new head 15f8338ca53b453df313313c794718650eed9473 after a normal merge of current main 4a5636a84f7a8f4eba8fad84cefa118f561dafe9 into the existing Desk delivery read-contract branch. The original eight contract file blobs are unchanged. Python full suite: 1174 tests, 12 skipped, zero failures/errors, with the authorized private compatibility-root isolation. Desk/API/receipt transport, operations, TypeScript/Vite build, budgets, documentation phase 2, syntax and deployment-safety checks passed.

Keep this PR Draft. No merge, labels or deployment are requested. Old-head reviews and CI are not current-head acceptance. Please emit exact-current-head structured code and security findings fields; null or missing security booleans remain UNKNOWN_NOT_CLEAN. Review completion is handled by the existing asynchronous parent path; no review polling or new listener is requested.

chatgpt-codex-connector · 2026-11-10T09:13:32Z

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 15f8338ca5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-11-10T09:15:51Z

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 15f8338ca5

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

feat: Add the Desk delivery read contract

309a316

This was referenced Nov 10, 2026

主线待办清单（中文） QuantStrategyLab/.github#40

Open

量化主线进度 QuantStrategyLab/.github#36

Open

chore(merge): sync main into feat/desk-delivery-read-contract

15f8338

Navigation Menu

Repository navigation

feat: Add the Desk delivery read contract - #1108

feat: Add the Desk delivery read contract#1108
Pigbibi wants to merge 2 commits into
mainfrom
feat/desk-delivery-read-contract

Pigbibi commented Nov 10, 2026

Uh oh!

Pigbibi commented Nov 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 10, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Nov 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 10, 2026

Uh oh!

Pigbibi commented Nov 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 10, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Pigbibi commented Nov 10, 2026

AI assistance

What changed

How verified

Why

Risk

Publication check

Uh oh!

Pigbibi commented Nov 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Nov 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 10, 2026

🛡️ Codex Security Review · Automatically triggered

Uh oh!

Pigbibi commented Nov 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 10, 2026

🛡️ Codex Security Review · Automatically triggered

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chatgpt-codex-connector Bot commented Nov 10, 2026 •

edited

Loading