Repository navigation
fix(desk): label fixtures across page and shell data - #1103
Merged
Merged
Conversation
The mock chip followed only session and ribbon, so a page could show fixtures without a label once a live endpoint landed. Derive exposure from DESK_PAGE_ENDPOINTS, add a partial-mock state with zh-CN/en copy, and name fixtures on the logs, alerts-delivery and strategy-catalog panels. Tests cover per-page exposure, the rendered partial chip in both languages and key parity; v2_asset_map.js regenerated. No backend or deployment change.
Pigbibi
marked this pull request as ready for review
November 9, 2026 20:25
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Native Claude implemented and accepted the frontend candidate and correction (model not recorded in the handoff). Codex (GPT-6; more specific runtime model unavailable) performed mechanical publication, main synchronization and offline verification. Codex added no frontend logic.
What changed
Identify fixture data across each Desk page and the surrounding shell. Mixed live and fixture reads show a localized partial-mock chip, with explicit labels for fixture-backed logs, alert delivery and strategy catalogs. The global ribbon remains included when page endpoints become live. Regenerate the existing asset map from the accepted sources.
How verified
Why
A live page endpoint must not hide the fixture label while the shell or other visible page content still uses fixtures. Users need to distinguish mixed-source data before interpreting the page.
Risk
Low-risk frontend labeling, tests and generated assets only. No Worker/backend, source-mode flips, pin changes or workflow changes in the feature delta. Read the workflow side-effect audit and verified deployment/release entry points remain manual-only; PR-triggered bundle jobs only validate. No deploy, upload, activation, rollback, Secrets, IAM or trading-switch operation. Parent and the established review-and-merge bot own subsequent disposition. Map maintenance is still required when page/shell endpoints change. Runtime adoption and production visual acceptance remain unverified.
Publication check
Central checker:
publication-check/2.0-advisory, build83d9d1130377,--git ., advisory exit 0; 4123 total findings across 4120 matching lines. Findings retained without new exemptions. This count is not a credential classification or a clean-tree claim. Adapter scope and handoff hashes are unchanged. First 20 entries below are shared-masker output.