Skip to content

fix: pin P02 capture to the reviewed control revision - #1102

Merged
Pigbibi merged 2 commits into
mainfrom
fix/p02-pinned-capture-entry
Nov 9, 2026
Merged

Pigbibi merged 2 commits into
mainfrom
fix/p02-pinned-capture-entry

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

AI assistance

Codex, GPT-6.1 Sol and GPT-6.1 Terra.

What changed

Bind the manual P02 capture to the approved control commit and tree in main history. Confirm that the dispatch workflow matches the reviewed launcher before checking out the pinned revision. Validate the protected capability before installing dependencies, and bind the capture to the reviewed backend and already published assets.

How verified

  • The fixed offline build matched the previously published bundle byte for byte.
  • Eleven targeted tests, six Git entry fixtures, Actionlint, and the diff whitespace check passed.
  • A simulated capture with the reviewed bundle exercised exact-generation readback. A different module stopped before creating the result.
  • The exact publication review preserves the six original findings and uses only approved, precisely scoped dispositions.

Why

Unrelated main updates should not invalidate a reviewed capture revision. The run still needs to verify the actual active module and record its point-in-time configuration.

Risk

High. This modifies the protected manual capture workflow. It preserves the existing environment, identity, concurrency group, storage object and bounded readback. The PR does not trigger capture or authorize upload, activation, rollback or sender changes.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi Pigbibi added risk:high Protected paths require owner approval as determined by the risk gate. needs-owner-approval The owner must apply owner-approved before this high-risk pull request can merge. labels Nov 9, 2026
@Pigbibi
Pigbibi marked this pull request as ready for review November 9, 2026 18:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T18:57:05.441571Z 26d323d Manual request
🔒 Security Review ✅ Completed 2026-11-09T18:58:45.229653Z 26d323d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c79e1941c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/console_p02_baseline_hosted.mjs Resolved
Comment thread scripts/console_p02_baseline_hosted.mjs Resolved
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi

Pigbibi commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Please review the current head 26d323d. The follow-up binds offline preparation to the same active-module digest and control tree as hosted capture, and documents the control_tree receipt field. Please verify the complete current-head diff and publish the configured review receipt.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 26d323df94

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 9, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 26d323df94

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@Pigbibi
Pigbibi merged commit a4d6c91 into main Nov 9, 2026
19 of 20 checks passed
@Pigbibi
Pigbibi deleted the fix/p02-pinned-capture-entry branch November 9, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation needs-owner-approval The owner must apply owner-approved before this high-risk pull request can merge. risk:high Protected paths require owner approval as determined by the risk gate.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant