Skip to content

refactor: Share digest schedule semantics across clouds - #1100

Merged
Pigbibi merged 2 commits into
mainfrom
refactor/digest-schedule-adapters
Nov 9, 2026
Merged

Pigbibi merged 2 commits into
mainfrom
refactor/digest-schedule-adapters

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

AI assistance

Codex, with GPT-6.1 Terra for the implementation.

What changed

Share business-day and operation derivation across digest schedule adapters. Provide an Azure scheduled-time adapter and cover Azure window validation, Google timestamp tolerance, and the existing digest delivery behavior.

How verified

The offline digest suite passed 163 tests and 72 subtests. The outgoing commit passed Gitleaks and the Git whitespace check.

Why

The original trigger timestamp should yield the same business operation across hosting platforms. Each provider keeps its existing input validation.

Risk

R1. The change preserves existing schedule precision rules and delivery ledger behavior. Production adoption requires a separate release and natural-cycle verification.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi marked this pull request as ready for review November 9, 2026 15:10
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T15:17:59.457496Z afbbe3f Manual request
🔒 Security Review ✅ Completed 2026-11-09T15:19:32.606015Z afbbe3f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi

Pigbibi commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: afbbe3f55c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi
Pigbibi merged commit a162820 into main Nov 9, 2026
16 of 17 checks passed
@Pigbibi
Pigbibi deleted the refactor/digest-schedule-adapters branch November 9, 2026 15:18
@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: afbbe3f55c

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant