Repository navigation
fix: Allow additive test handlers in reviewed main release - #1095
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
b73c0d3 to
9a38920
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a38920553
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Pigbibi
added
the
agent-approved
AI assistance
AI: DeepSeek coding agent (Qoder Desktop session). Owner Pigbibi approved this gate change (option A) for the frontend release line of
.github#36/.github#40.What changed
.github/workflows/deploy-strategy-switch-console.yml: in reviewed-main release mode only, treat the test-only__testnamed-handler export as code rather than configuration. All other named handlers stay strictly equal;__testhandlers may only be added, never removed, and the export's presence/shape must match (new checkpointstest_export_shape_mismatch,test_export_handlers_removed). Additions are recorded asreviewed_main_test_export_handlers_added. Post-release readback additionally requires the activated version's__testexport to exactly equal the validated upload (post_release_test_export_mismatch), so the relaxed hash cannot hide export loss after activation. Non-reviewed flows keep the strict hash comparison unchanged.scripts/console_version_comparator.mjs: mirror the newcomparableblock to satisfy the static pin test, withallowTestHandlerAdditions = falseso the read-only comparator stays strict and still surfaces test-handler diffs.tests/console_deploy_safety_validation.mjs: new integrated release cases covering additive__testhandlers (pass + recorded), removal (stop), shape change (stop), non-test handler change (stop), additive handlers outside reviewed-main mode (stop), and post-activation readback with shrunk or omitted__test(stop atpost_release_test_export_mismatch). Fail-before proof confirmed for both the gate change and the readback fix.How verified
node --test tests/console_deploy_safety_validation.mjs: all pass, including 257 isolated release cases and the 5 new cases.node --test tests/console_version_comparator_validation.mjsand nearby comparator tests: pass (static pin satisfied).actionlinton the workflow: exit 0.configuration_hash_mismatchbecause candidatebff806e0adds exactly 5 test-only handlers to__test(credentialRotationResponse,deskAuth,deskTargetReadback,runtimeInstanceCommand,splitSelectorValues) vs live baselineead1e472;RuntimeInstancesand all bindings are unchanged.Why
The frontend release (reviewed main
084ba428) cannot activate because the release gate hashesscript.named_handlerswholesale, and the reviewed source legitimately adds test-only exports under__test. The gate blocked a code-only additive change as a configuration drift. This change lets reviewed-main releases admit additive test handlers while keeping every real configuration surface (bindings, runtime, handlers, other named handlers, placement) strictly compared.Risk
Medium (release gate logic), owner-approved. Scope is limited to
reviewedMainmode; resume/off and external flows keep the previous strict behavior. Removal or shape change of__teststill stops the release before activation. RO-M07 remains HOLD and is not touched.AI: DeepSeek coding agent.