Skip to content

fix: Diagnose active Worker asset differences - #1093

Merged
Pigbibi merged 1 commit into
mainfrom
fix/qrs-worker-active-asset-compare
Nov 8, 2026
Merged

Pigbibi merged 1 commit into
mainfrom
fix/qrs-worker-active-asset-compare

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

AI assistance

Codex implemented and validated the candidate. GPT-6.1 Terra independently reviewed the comparison and the fixed read path.

What changed

  • Add a manual asset comparison action for the fixed QRS Worker candidate.
  • Compare three compiled asset declarations. The job reads the active deployment, its module and the deployment again, with no retry.
  • Report declaration equality and fixed stop reasons. The separate release action retains its existing hold.

How verified

  • Tested the offline comparator and the complete CLI with a mocked GET transport. A candidate digest mismatch stops before the first request.
  • Local actionlint and targeted tests passed. The organization scan retained one original finding in a generated Git object header and applied its two precisely approved spans. Zero findings remain.
  • Push and merge do not trigger a production release job.

Why

Determine which serving frontend declarations match the held backend candidate before making a new release decision.

Risk

R2 for protected Worker workflow code. This PR adds an explicitly selected read-only action. Upload, activation, rollback and producer switching remain separately governed.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi marked this pull request as ready for review November 8, 2026 19:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T19:10:11.198253Z 1378dd7 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-08T19:12:54.311743Z 1378dd7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 8, 2026
@Pigbibi
Pigbibi merged commit 1a4d5e0 into main Nov 8, 2026
20 of 22 checks passed
@Pigbibi
Pigbibi deleted the fix/qrs-worker-active-asset-compare branch November 8, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant