Skip to content

feat: Simplify the account daily digest - #1088

Merged
Pigbibi merged 5 commits into
mainfrom
fix/account-daily-digest-v1
Nov 8, 2026
Merged

Pigbibi merged 5 commits into
mainfrom
fix/account-daily-digest-v1

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

AI assistance

Codex, with Sol 6.1 coordination and Terra 6.1 implementation and review support.

What changed

  • Render a concise Chinese or English account digest with account and strategy labels, order and fill counts, execution details, and independently verifiable assets and positions.
  • Preserve known balances and holdings when trades are missing or the source is stale. Keep unverified counts unknown and deduplicate fills within the existing reporting window.
  • Use the existing Cloud Run sender and receipt flow. This release uses its ordinary inputs.
  • Publish the optional account facts producer contract. Preserve account label disambiguation, normalize order status for presentation, and merge equivalent snapshot instants.

How verified

  • 55 focused local tests, including the existing Cloud Run entry, bilingual rendering and image file checks. Ruff passed.
  • Three simulated storage scenarios verify that the ordinary release does not fetch supplemental fills.
  • Review follow-up: 304 daily-path tests and two JSON Schema tests passed. Ruff passed.
  • The project publication gate retained the 19 original findings and reported zero unresolved findings on the follow-up tree. GitHub checks and current-head review remain required.

Why

An idle or incomplete report could hide known balances and positions or imply that trading had been verified. The account layout now displays verified facts and calls out incomplete coverage.

Risk

R2. Changes the production digest renderer and Cloud Run entry behavior. Sender schedule, reservation, deduplication, and receipt semantics stay on the existing path. Supplemental IBKR settlement-fill intake is outside this release. Rollout and natural-run acceptance are separate from PR merge.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi marked this pull request as ready for review November 8, 2026 13:52
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T14:19:45.412611Z ead549b New commits
🔒 Security Review ✅ Completed 2026-11-08T14:21:20.213444Z ead549b New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f054b1e0b7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread python/scripts/account_daily_facts.py Resolved
Comment thread python/scripts/account_daily_digest.py Resolved
Comment thread python/scripts/account_daily_digest.py Resolved
Comment thread python/scripts/account_daily_facts.py Resolved
Co-Authored-By: Codex <noreply@openai.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b4219e15a9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread python/scripts/account_daily_facts.py Resolved
Comment thread python/scripts/account_daily_digest.py Resolved
Pigbibi and others added 2 commits November 8, 2026 22:10
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b63174c580

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread python/scripts/account_daily_facts.py Resolved
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 8, 2026
@Pigbibi
Pigbibi merged commit a1c42cb into main Nov 8, 2026
19 of 20 checks passed
@Pigbibi
Pigbibi deleted the fix/account-daily-digest-v1 branch November 8, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant