Skip to content

fix: Preserve daily caller presentation and run evidence - #1083

Merged
Pigbibi merged 2 commits into
mainfrom
fix/daily-caller-presentation
Nov 7, 2026
Merged

Pigbibi merged 2 commits into
mainfrom
fix/daily-caller-presentation

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

AI assistance

Codex (gpt-6.1-sol).

What changed

Keep the existing five-section operator display in the central daily caller,
coverage details and unified deadline fallback. Present the unbound Binance
inventory as disabled under the standing owner OFF decision, with runs/orders/
fills N/A. Missing inventory and other unbound sources remain unknown; a bound
Binance target retains its real coverage.

Pass an already supplied source-run URL only when it matches the platform's
configured repository and canonical HTTPS <PROJECT_ID> Actions run path. Reuse the
shared URL sanitizer to remove query/fragment; otherwise show an unavailable
marker. Do not construct URLs from run IDs. Preserve counts, incident state,
business windows, reservations and delivery receipts.

How verified

  • Tests first: fail-before output records the disabled/link/fallback gaps.
  • Final isolated Python suite: 1147 tests, PASS, 10 skipped. Candidate file
    comparison: all nine changed files byte-identical to the validated checkout.
  • Seven new presentation tests, bilingual golden snapshots, URL rejection,
    not-run coverage and unknown whole-window scope; existing 13 projection
    tests verify diagnostics within the 1024-unit budget.
  • Generated display/config checks, runtime-target validation, package build,
    documentation style and whitespace checks pass (one existing README advisory).
  • The shared workspace initially exposed three compatibility-test failures
    because sibling repositories affect discovery. The same untouched checker
    passes in the isolated full-suite environment. One introduced budget overflow
    was fixed by shortening only the caller's English coverage sentence.

Why

Source-level five-section support did not establish central caller adoption.
The caller lost the known-disabled Binance distinction and did not supply
safe source-run navigation or its explicit unavailable status.

Risk

R1: presentation-only backend change. No new sender, schema or service. No
frontend workflow or frontend asset pin change. No deploy, production messages,
collection, backend activation, Environment approval, Secret/IAM, trading,
Kelly, stop-loss or session renewal. Missing deployed revision and natural
producer/delivery receipts remain NOT_PROVEN; source tests and merge cannot
prove runtime adoption. Prepared for one exact-head review request; no merge or labels.

Main synchronization verification

Merged main f9d8c99e7bfd0628aa68e2cb9b429632a2bc56d6 without conflicts using an ordinary merge. New head c383dd244e87fa5499ab7d60b801649e824fb567. All nine feature files are byte-identical to the prior reviewed candidate; the comparator delta from main is retained.

Fresh checks: seven presentation regressions PASS; isolated full Python suite 1147 tests PASS / 10 skipped; generated display/configuration and runtime validation PASS; package source/wheel build PASS; documentation and whitespace PASS; comparator and deploy-safety suites PASS. The first archive-only validation lacked Git metadata; the Git clone run passes without a source change. Python 3.13 locally; hosted Python 3.12 and required js remain separate checks.

Fresh exact-head review is requested for this integrated candidate; the prior review does not accept this head. Keep Draft for a separate merge job. No labels, undraft, merge, deploy, Secret/IAM or production actions from this job. Runtime adoption remains NOT_PROVEN.

Central publication scan

Checker: publication-check/2.0-advisory (build 83d9d1130377). Advisory mode.
Total matches: 4028 matching lines (4031 checker findings).
Complete synchronized tracked tree scanned. No new credential identified in the feature delta.
First 20 masked matches:

.github/CODEOWNERS:4 /.github/CODEOWNERS @<PROJECT_ID>
.github/CODEOWNERS:5 /.github/workflows/ @<PROJECT_ID>
.github/CODEOWNERS:6 /actions/publish-runtime-execution-evidence/ @<PROJECT_ID>
.github/CODEOWNERS:7 /python/scripts/check_credential_maintenance_read.py @<PROJECT_ID>
.github/CODEOWNERS:8 /python/scripts/credential_maintenance_notify.py @<PROJECT_ID>
.github/CODEOWNERS:9 /python/scripts/deployment_bundle_contract.py @<PROJECT_ID>
.github/CODEOWNERS:10 /python/scripts/deterministic_risk_gate.py @<PROJECT_ID>
.github/CODEOWNERS:11 /python/scripts/execution_evidence_projection.py @<PROJECT_ID>
.github/CODEOWNERS:12 /python/scripts/forward_observation_risk_control.py @<PROJECT_ID>
.github/CODEOWNERS:13 /python/scripts/long_horizon_risk_composer.py @<PROJECT_ID>
.github/CODEOWNERS:14 /python/scripts/long_horizon_risk_composer_v2.py @<PROJECT_ID>
.github/CODEOWNERS:15 /python/scripts/long_horizon_risk_observation_ingress.py @<PROJECT_ID>
.github/CODEOWNERS:16 /python/scripts/long_horizon_risk_observation_ingress_v2.py @<PROJECT_ID>
.github/CODEOWNERS:17 /python/scripts/paper_risk_admission_receipt.py @<PROJECT_ID>
.github/CODEOWNERS:18 /schemas/qsl-deployment-bundle.v1.schema.json @<PROJECT_ID>
.github/CODEOWNERS:19 /schemas/qsl-forward-observation-risk-control.v1.schema.json @<PROJECT_ID>
.github/CODEOWNERS:20 /schemas/qsl-reconcile-only-risk-control.v1.schema.json @<PROJECT_ID>
.github/CODEOWNERS:21 /scripts/provision_binance_recovery_credentials.sh @<PROJECT_ID>
.github/CODEOWNERS:22 /scripts/provision_soxl_v7_review_credential.py @<PROJECT_ID>
.github/CODEOWNERS:23 /web/strategy-switch-console/application/console_api/strategy_execution.js @<PROJECT_ID>

@Pigbibi

Pigbibi commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Please review the current Draft head 45569a2b4a8d for the bounded daily caller
presentation changes. This requests one review of this exact candidate only.
Runtime adoption remains NOT_PROVEN; no deployment or activation is requested.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T12:52:23.954727Z c383dd2 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-07T12:54:14.022191Z c383dd2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 45569a2b4a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi

Pigbibi commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Please review the new exact head c383dd244e87fa5499ab7d60b801649e824fb567 after the ordinary merge of current main into this Draft. The nine-file daily-caller feature is byte-identical to the prior reviewed candidate. Seven focused tests and the isolated full Python suite (1147 tests, 10 skipped), configuration checks, package build, documentation, comparator and deploy-safety checks pass. Review the integrated candidate; prior acceptance is not reused for this head. No merge, undraft, label, deployment or activation is requested.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: c383dd244e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi
Pigbibi marked this pull request as ready for review November 7, 2026 12:49
@Pigbibi
Pigbibi merged commit 2e98243 into main Nov 7, 2026
18 of 21 checks passed
@Pigbibi
Pigbibi deleted the fix/daily-caller-presentation branch November 7, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant