Repository navigation
fix: Preserve daily caller presentation and run evidence - #1083
Conversation
|
@codex review Please review the current Draft head |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Please review the new exact head |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
AI assistance
Codex (gpt-6.1-sol).
What changed
Keep the existing five-section operator display in the central daily caller,
coverage details and unified deadline fallback. Present the unbound Binance
inventory as disabled under the standing owner OFF decision, with runs/orders/
fills N/A. Missing inventory and other unbound sources remain unknown; a bound
Binance target retains its real coverage.
Pass an already supplied source-run URL only when it matches the platform's
configured repository and canonical HTTPS <PROJECT_ID> Actions run path. Reuse the
shared URL sanitizer to remove query/fragment; otherwise show an unavailable
marker. Do not construct URLs from run IDs. Preserve counts, incident state,
business windows, reservations and delivery receipts.
How verified
comparison: all nine changed files byte-identical to the validated checkout.
not-run coverage and unknown whole-window scope; existing 13 projection
tests verify diagnostics within the 1024-unit budget.
documentation style and whitespace checks pass (one existing README advisory).
because sibling repositories affect discovery. The same untouched checker
passes in the isolated full-suite environment. One introduced budget overflow
was fixed by shortening only the caller's English coverage sentence.
Why
Source-level five-section support did not establish central caller adoption.
The caller lost the known-disabled Binance distinction and did not supply
safe source-run navigation or its explicit unavailable status.
Risk
R1: presentation-only backend change. No new sender, schema or service. No
frontend workflow or frontend asset pin change. No deploy, production messages,
collection, backend activation, Environment approval, Secret/IAM, trading,
Kelly, stop-loss or session renewal. Missing deployed revision and natural
producer/delivery receipts remain NOT_PROVEN; source tests and merge cannot
prove runtime adoption. Prepared for one exact-head review request; no merge or labels.
Main synchronization verification
Merged main
f9d8c99e7bfd0628aa68e2cb9b429632a2bc56d6without conflicts using an ordinary merge. New headc383dd244e87fa5499ab7d60b801649e824fb567. All nine feature files are byte-identical to the prior reviewed candidate; the comparator delta from main is retained.Fresh checks: seven presentation regressions PASS; isolated full Python suite 1147 tests PASS / 10 skipped; generated display/configuration and runtime validation PASS; package source/wheel build PASS; documentation and whitespace PASS; comparator and deploy-safety suites PASS. The first archive-only validation lacked Git metadata; the Git clone run passes without a source change. Python 3.13 locally; hosted Python 3.12 and required js remain separate checks.
Fresh exact-head review is requested for this integrated candidate; the prior review does not accept this head. Keep Draft for a separate merge job. No labels, undraft, merge, deploy, Secret/IAM or production actions from this job. Runtime adoption remains NOT_PROVEN.
Central publication scan
Checker:
publication-check/2.0-advisory(build83d9d1130377). Advisory mode.Total matches: 4028 matching lines (4031 checker findings).
Complete synchronized tracked tree scanned. No new credential identified in the feature delta.
First 20 masked matches: