Repository navigation
fix(runtime): enforce Cloud Run service and tag budget - #1079
Merged
Merged
Conversation
Contributor
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Nov 5, 2026
Co-Authored-By: Codex <noreply@openai.com>
Pigbibi
marked this pull request as ready for review
November 5, 2026 20:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
OpenAI Codex; host model configuration: gpt-6.1-sol.
What changed
Reject Cloud Run service names that cannot satisfy the selected
cand-{sha8}tag contract before generating or forwarding a runtime inventory. The combined
budget is 46 characters, including a 13-character tag, so service names must fit
33 characters. Both TAG_IMPOSSIBLE and TAG_TIGHT names refuse generation; names
are never automatically shortened or renamed. Check generated defaults,
overrides, and every retained inventory name alias. Add explicit workflow failure
reporting, bilingual operating guidance, and regression coverage.
How verified
(20 adverse subtest failures), including 48-character refusal, redacted errors,
retained aliases, two CLI processes and actual workflow build-step execution.
Node 22.23.4. QRS946 bundle-only checks are skipped for unchanged scope, as in CI.
The initial Node 24 attempt stopped on a removed CLI flag; no gate was changed.
whitespace, documentation checks (zero blocking), and Python package build pass.
stale state is N/A because validation is synchronous and stateless.
Why
Owner decision t1255s7222 selects Option B. A 48-character service cannot fit any
nonempty tag. QRS previously allowed such a name to reach published inventory.
The concurrently assigned QPK helper had no stable delivered pin available when
integration was assessed, so this change uses the authorized small local module.
Existing positive tests use short fake names without weakening their assertions.
Risk
Risk tier: high (runtime builder and manual workflow paths). This changes offline
naming acceptance only. It intentionally refuses tighter names under this fixed
13-character contract, including retained inventory entries. Existing service
identities need separately approved migration. No merge, labels, deployment,
traffic, IAM, secrets, variables, live inventory mutation or service rename.
Runtime adoption and production switch states are not established by these tests.
Publication check
Central checker:
publication-check/2.0-advisory(build83d9d1130377), advisory exit 0. Total matches: 3934; matching lines: 3931; flagged files: 513. The complete tracked candidate tree was scanned. Counts are advisory under owner rule pt1114u; no credential is added by this patch. First 20 matches below use the shared masked text.