Repository navigation
feat(desk): Add credentials and strategies pages with retry states - #1074
Conversation
Pigbibi
left a comment
Pigbibi
left a comment
There was a problem hiding this comment.
Codex fallback code review for exact head 95f5abeb7f2c0c72cdde4803df0688b0970533e3, base 7ec591ae22578f2db47ebeda406fa62205cfdfb3. Verdict: BLOCKING (1 P1, 2 P2). All three findings have offline reproductions; the domain and rotation-link issues were also confirmed in a real browser. Local frontend build/budgets and operations tests pass; Python: 1127 tests, 10 skipped. Hosted JS remains red because the tracked generated assets are stale; governance is independently red. No code, labels, merge, deploy, credentials or IAM changes were made. This review is evidence, not merge/runtime acceptance.
|
Codex fallback review completed on the exact head above. Verdict: BLOCKING (1 P1, 2 P2), with three unresolved inline findings in review 5763706277: stale embedded Worker assets, target-domain catalog eligibility, and a rotation link returning 404. This marker records the dispatched fallback review, not an official app receipt or merge approval. Local frontend build and operations checks pass; Python ran 1127 tests with 10 skips. Hosted JS and governance remain red. No merge or deployment. Outgoing-artifact scan: |
|
@codex review Please review the three bounded fixes from qrs1074-review-r1 at exact head
Validation: complete operations suite PASS; Python 1127 tests OK (10 skipped); projections/config validation PASS; current-tree JS validation block PASS after removing an obsolete Node 22 CLI flag for local Node 24. CI-only fixed historical bundle evidence was not rebuilt locally. Build/type check/budgets, embedded resource bytes, style and whitespace PASS (existing advisory style warnings retained). The central publication checker is publication-check/2.0-advisory, build 2947dd7867b4; the complete tracked candidate has 3966 matches on 3963 lines (same counts as the prior review); first 20 locations are CODEOWNERS lines 4 through 23, with matching values omitted. The new test and outgoing message have 0 matches, first 20 empty. Masked scan details are retained in the job artifacts. Its result is advisory. No merge, label, deployment, production setting, Secret or IAM change is requested. Prepared by Codex (gpt-6.1-sol). |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Verified and ported the approved F1–F4 Meridian repairs. Authored by Codex (host-configured model). QRS #1074 F1–F4 delivery verificationGoalPort the approved Meridian frontend repairs onto the existing Draft PR, without redesign or backend changes. Evidence
Self-review
Publication checkChecker: publication-check/2.0-advisory; build: 83d9d1130377; total matches: 12; matching lines: 12. Advisory; inspected candidate matches contain no real credential. First 20 masked matches (all 12 shown):
Blockers and limitationsBrowser visual verification and Claude FE re-acceptance are pending. Local checks establish offline behavior only. Parent npm ci reported one moderate dependency advisory; dependencies were not changed. Next stepsClaude FE re-acceptance on the updated #1074 head, including browser visual checks. Full tracked-tree publication scanpublication-check/2.0-advisory; build 83d9d1130377; findings 3955; matching lines 3952. Includes pre-existing repository matches outside this frontend port; this job does not expand identifier cleanup scope. The changed-file scan above separately covers all 19 candidate files. First 20 masked full-tree matches:
|
Co-Authored-By: Codex <noreply@openai.com>
|
@codex review Please review exact synchronized head |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 315bb47b3b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review exact head This correction localizes Needs-you mock copy, links the credential runbook to the existing repository document, rejects old-target catalogs before initial-profile selection, and regenerates the tracked Worker assets. Existing non-US restrictions and Health rotation route remain covered by actual-caller tests. Five new adverse cases fail before and pass after; delivery 11/11, complete operations/contracts, 123 current-tree JS commands, Python 1,140 tests (10 skipped), package build and production frontend build pass. All 42 assets match the real Worker byte for byte. CSS is unchanged at 20,438 bytes gzip under the unchanged 20,480 limit here; historical +7B is not reproduced. Central checker Publication checker Prepared and verified by Codex (gpt-6.1-sol). |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Implemented by Qwen3.8-Flash via Qoder. Verified by Codex (gpt-6.1-sol). Repair Claude N1 only and regenerate the embedded Worker assets.
|
@codex review Review the exact updated Draft head
Prepared by Qwen3.8-Flash via Qoder; verified by Codex (gpt-6.1-sol). Complete tracked candidate publication scan:
|
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ac11011 to
1797020
Compare
|
@codex review Please complete the exact-head review for Draft PR #1074 at This owner-authorized repair changes only the published N1 tip commit message from Keep Draft. No labels, undraft, merge, deploy or Claude acceptance launch. Coordinator owns the subsequent Claude r3 dispatch after CLEAN. Verified by Codex (gpt-6.1-sol). Central checker Complete tracked candidate scan:
|
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Please review exact head This bounded repair retains the 1280px R1 breakpoints in CredentialTable.tsx and desk.css and regenerates v2_asset_map.js using npm run sync:v2-assets. Incremental patch: three files only. The unsynchronized Worker returned 404 for a new build resource; after generation all 42 resources resolve with identical bytes. Validation: frontend build/TypeScript/budget PASS; complete test:operations PASS, including the Worker regression (fail-before recorded, 11/11 pass-after); offline browser 32 width/language/theme combinations and continuous resize PASS; complete Python suite 1140 tests PASS (10 skipped). Central checker python3 scripts/check_style.py exit 0, zero blocking/one existing README advisory. Style guards exit 0 (one existing warn-only color literal, zero theme parity findings); diff whitespace check PASS. Authored and verified by Codex (GPT-6, host-selected model). Keep Draft. No labels, undraft, merge, deploy or changes to protected switches. Coordinator owns Claude fe-accept-qrs1074-r4 after exact-head CLEAN. Complete tracked-tree scan: publication-check/2.0-advisory, build 83d9d1130377, advisory exit 0; 3964 matches / 3961 matching lines. First 20 masked entries:
|
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Pigbibi
added
the
agent-approved
AI assistance
Codex (gpt-6.1-sol) implemented the bounded findings correction using the explicitly authorized fallback, verified it and updated this Draft. Qoder CLI / Qwen3.8-Flash was attempted but produced no patch because required shell commands could not run in the host confirmation mode. The original feature implementation remains in the existing branch history.
What changed
Complete the Meridian Accounts/Credentials, Overview needs-you and Strategies preview pages while preserving the approved routes, bilingual UI, light/dark themes, mock-data labeling and disabled trading writes.
This findings correction localizes mock Needs-you titles/details/actions through the existing locale tables, links credential instructions to the existing repository document, and prevents a previous target's ready strategy catalog from selecting or rendering profiles for a new target. Catalog revision and loading state follow the same target identity. Unknown backend copy remains readable. Regenerate the committed Worker asset map through the existing pipeline.
The historical Binance/HK domain restrictions and
/?page=healthrotation route already pass their real-caller regressions and are preserved. The mock privacy test exempts only the exact public runbook URL in the runbook field; arbitrary hosts, modified URLs, emails and the same URL in other fields remain rejected.How verified
python3 scripts/check_style.py: exit 0, zero blocking and one advisory. Whitespace: PASS.Exact-head review at
6cf4395ba09995a1b101f52d6063fb8ebae2b80d: completed, has_any_findings=false, has_unresolved_findings=false. All six historical threads are resolved. Hosted frontend build, size budgets and operations pass, but the overall hostedjscheck fails in the unchanged UX research demo test with a workerd bind/address-in-use error. That test and demo are identical to main and their local current-tree command passed; no hosted baseline-equivalence or overall CI pass is claimed. Native governance/risk gates remain enforced, with no clearing label applied.Why
The new pages must stay bilingual, offer reachable maintenance instructions and use a catalog belonging to the selected target. The previous ready snapshot could reselect a wrong-target strategy during an asynchronous read.
Risk
Draft update only. No backend contract, production configuration, workflow, dependency or protected switch change; no deployment or runtime acceptance. Native governance and risk gates remain enforced. Claude FE reacceptance follows an exact-head completed review with unresolved=false.
Qoder CLI / Qwen3.8-Flash was attempted but could not run required shell commands under the host confirmation mode and produced no patch; that job-owned child was stopped. Codex (gpt-6.1-sol) implemented the authorized minimal fallback, verified and published this correction.
Publication check
Checker
publication-check/2.0-advisory, build83d9d1130377: advisory total match count 3964, matching lines 3961. The scan completed (exit 0); advisory matches are not a publication approval or a native-gate override. No real credential is introduced by this correction.First 20 shared-masker entries:
repo/.github/CODEOWNERS:4:/.github/CODEOWNERS @<PROJECT_ID>repo/.github/CODEOWNERS:5:/.github/workflows/ @<PROJECT_ID>repo/.github/CODEOWNERS:6:/actions/publish-runtime-execution-evidence/ @<PROJECT_ID>repo/.github/CODEOWNERS:7:/python/scripts/check_credential_maintenance_read.py @<PROJECT_ID>repo/.github/CODEOWNERS:8:/python/scripts/credential_maintenance_notify.py @<PROJECT_ID>repo/.github/CODEOWNERS:9:/python/scripts/deployment_bundle_contract.py @<PROJECT_ID>repo/.github/CODEOWNERS:10:/python/scripts/deterministic_risk_gate.py @<PROJECT_ID>repo/.github/CODEOWNERS:11:/python/scripts/execution_evidence_projection.py @<PROJECT_ID>repo/.github/CODEOWNERS:12:/python/scripts/forward_observation_risk_control.py @<PROJECT_ID>repo/.github/CODEOWNERS:13:/python/scripts/long_horizon_risk_composer.py @<PROJECT_ID>repo/.github/CODEOWNERS:14:/python/scripts/long_horizon_risk_composer_v2.py @<PROJECT_ID>repo/.github/CODEOWNERS:15:/python/scripts/long_horizon_risk_observation_ingress.py @<PROJECT_ID>repo/.github/CODEOWNERS:16:/python/scripts/long_horizon_risk_observation_ingress_v2.py @<PROJECT_ID>repo/.github/CODEOWNERS:17:/python/scripts/paper_risk_admission_receipt.py @<PROJECT_ID>repo/.github/CODEOWNERS:18:/schemas/qsl-deployment-bundle.v1.schema.json @<PROJECT_ID>repo/.github/CODEOWNERS:19:/schemas/qsl-forward-observation-risk-control.v1.schema.json @<PROJECT_ID>repo/.github/CODEOWNERS:20:/schemas/qsl-reconcile-only-risk-control.v1.schema.json @<PROJECT_ID>repo/.github/CODEOWNERS:21:/scripts/provision_binance_recovery_credentials.sh @<PROJECT_ID>repo/.github/CODEOWNERS:22:/scripts/provision_soxl_v7_review_credential.py @<PROJECT_ID>repo/.github/CODEOWNERS:23:/web/strategy-switch-console/application/console_api/strategy_execution.js @<PROJECT_ID>