Repository navigation
refactor: split platform entry into route modules - #741
Conversation
Keep main as an explicit named re-export surface for tests and process entry, with routes and wiring moved into dedicated modules. Co-authored-by: Cursor <cursoragent@cursor.com>
Pigbibi
added
risk:low
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0031721e66
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Align LongBridge entry with explicit re-export facade and point i18n extract tests at notifications_runtime after the split. Co-authored-by: Cursor <cursoragent@cursor.com>
Pigbibi
added
agent-approved
Align with Binance Wave2: main is a named-export module facade only, with Flask/wiring living in split modules. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a59303a7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
http_routes entry proxy now accepts script launch as __main__, and py-modules lists the extracted runtime modules for installed imports. Co-authored-by: Cursor <cursoragent@cursor.com>
Script launches and facade-qualified notification helpers need the same entrypoint resolution and a main stand-in for source extraction tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Pigbibi
added
agent-approved
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e7b88ed3c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Stop forwarding setattr into implementation modules so patch.object deletion returns __getattr__ to the real callables. Co-authored-by: Cursor <cursoragent@cursor.com>
Pigbibi
added
agent-approved
AI assistance
Cursor Auto (Composer) with local agent session. Owner authorized commit,
push, and PR for untangle Wave2.
What changed
main.pysplit intohttp_routes,runtime_wiring,notifications_runtime, andstrategy_plugins_runtime.main.pyis a Binance-style thin facade: explicit named re-exportsonly (no
import */_export), plus a module facade that forwardsattribute writes to the owning implementation module.
main.main.<name>proxy in splitmodules; split modules reload when
mainreloads.How verified
compileallon split modules.pytest tests/test_request_handling.py: 65 passed; 1 failed(
test_health_route_returns_ok) also fails onorigin/maindue tolocal env pin (
quant_platform_kit.strategy_contractsmissing) — not asplit regression.
Why
Prior #738 closed after
import */_exportpublic surface caused realregressions. Wave2 redo follows the Binance thin-main pattern so tests and
process entry keep a stable, patchable
mainsurface.Risk
Low structure-only refactor. Labels:
agent-approved+risk:lowonly.