Skip to content

fix(observation): enable the SG snapshot on its serving image - #732

Merged
Pigbibi merged 2 commits into
mainfrom
fix/sg-serving-snapshot-switch
Nov 11, 2026
Merged

Pigbibi merged 2 commits into
mainfrom
fix/sg-serving-snapshot-switch

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

AI assistance

Implementation and verification assisted by Codex.

What changed

  • Add an explicit SG-only mode to the existing Cloud Run release workflow. It reuses the exact serving image and changes only the account snapshot flag while the trading target is disabled.
  • Verify the staged revision before routing traffic. The internal verifier can check SG account binding and cannot write an HK archive for SG.

How verified

  • Actionlint and Ruff passed.
  • 16 focused release and verifier tests passed.
  • Existing release shell scenarios passed, including 92 no-traffic cases.
  • Cloud Run accepted the one-flag validation-only request on the current SG service. No production mutation was part of that preflight.

Why

The internal SG account snapshot handler is present in the serving image but disabled. A dedicated release path keeps the account observation independent of strategy execution.

Risk

The mode is scoped to the protected SG environment and the current immutable serving source. A disabled trading target, internal ingress, the current revision, and matching configuration are required before promotion. No credentials, account data, trading switches, or order routes are changed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T11:45:32.815826Z e2591ea New commits
🔒 Security Review ✅ Completed 2026-11-11T11:51:01.978243Z e2591ea New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 16f616301b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/enable_sg_serving_snapshot.py Resolved
Comment thread scripts/enable_sg_serving_snapshot.py Resolved
@Pigbibi Pigbibi added agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation and removed agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation labels Nov 11, 2026
@Pigbibi
Pigbibi merged commit e154561 into main Nov 11, 2026
15 of 18 checks passed
@Pigbibi
Pigbibi deleted the fix/sg-serving-snapshot-switch branch November 11, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant