Repository navigation
ci: Diagnose protected mapping read failures safely - #721
Merged
Merged
Conversation
Collaborator
Author
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Pigbibi
marked this pull request as ready for review
November 6, 2026 20:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
OpenAI Codex, gpt-6.1-sol.
What changed
Report the failing protected mapping's fixed variable name, lookup scope and allowlisted error category in the first mapping-read action. Preserve masking before authentication, zero exports on failure and Environment-first lookup with same-name repository fallback only on HTTP 404. Document the categories and add fake-only adverse tests.
How verified
Why
The first protected-mapping step previously replaced every failure with a generic message, preventing offline diagnosis from distinguishing authorization, absence, malformed responses and transport failure. Raw exception/URL/response/header/value payloads remain excluded.
Risk
High: protected workflow path, limited to pre-authentication observability. No token permission change, execution-gate change, IAM/Secret/Environment configuration write, workflow dispatch, grant retry, apply or PAPER start. Offline tests do not prove real Variables API access or deployed adoption. Draft only; review/merge is separate. Any protected execution remains a separate owner card.
Publication check
Central checker
publication-check/2.0-advisorybuild83d9d1130377(advisory): findings=1498, total matching lines=1487. Complete tracked candidate tree scanned. Added-line matching count=0 (121 added lines); existing-tree findings are not an authorization or credential disclosure. First 20 masked matches:.env.example:21—TELEGRAM_TOKEN=<<HOST>>.<PROJECT_ID>/CODEOWNERS:7—/.env.example @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:8—/.github/CODEOWNERS @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:9—/.github/workflows/ @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:10—/application/account_new_risk_gate_support.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:11—/application/durable_execution_commands.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:12—/application/execution_receipt_adapter.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:13—/application/execution_service.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:14—/application/execution_state.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:15—/application/longbridge_execution.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:16—/application/paper_execution_command_consumer.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:17—/application/paper_strategy_risk_state.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:18—/runtime_execution_policy.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:19—/scripts/execution_report_heartbeat.py @<PROJECT_ID>.<PROJECT_ID>/dot-review/review.cjs:106—const token = <REDACTED> core.getIDToken(audienceText); // Exact bytes; URL normalization may change an audience..<PROJECT_ID>/dot-review/review.cjs:190—const <PROJECT_ID> = {...pr,head:{...pr.head,sha:pair.target},base:{...pr.base,sha:pair.base}};.<PROJECT_ID>/dot-review/review.cjs:191—const binding = {...b.binding({repository:trust.repo.full_name,pr:<PROJECT_ID>,policyCommit:trust.commit,files},trust.policySha),.<PROJECT_ID>/dot-review/test-review.cjs:81—const content='<PROJECT_ID> source\n', sourceSHA='d'.repeat(40);.<PROJECT_ID>/dot-review/test-review.cjs:82—const pr={number:7,changed_files:1,commits:1,title:'<PROJECT_ID> change',body:'<PROJECT_ID> body',.<PROJECT_ID>/dot-review/test-review.cjs:100—assert.equal(audience,'https://audience.example.test');return '<PROJECT_ID>-only';},summary};