Repository navigation
fix: Observe executor permissions before PAPER IAM reads - #719
Merged
Merged
Conversation
Collaborator
Author
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Pigbibi
marked this pull request as ready for review
November 6, 2026 14:59
Pigbibi
added
the
agent-approved
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The executor's first role GET can return HTTP 403 without establishing the
missing permission. Add one bounded read-only projects.testIamPermissions
preflight over exactly iam.roles.get, resourcemanager.projects.getIamPolicy,
iam.roles.create and resourcemanager.projects.setIamPolicy.
Emit only fixed status/phase categories and the ordered missing allowlist subset.
Cap response input at 4096 bytes; malformed or failed observations stop with exit
1 and no retry or arbitrary remote output. A valid omitted permissions field
means none held. The result never authorizes a write. Original role/policy reads,
GET 404 handling, HTTP categories, identity checks, CAS and dry-run/apply gates
remain unchanged. Update the existing design note and fake-only tests.
How verified
Scope and risk
Diagnostic observability code only. No cloud probe, dry-run, apply, IAM write,
Environment approval, Secret change, workflow dispatch or PAPER start.
Engineering merge only after exact-head CLEAN review and required checks pass.
Point-in-time permission observations do not prove API availability or successful
execution. Project setIamPolicy authority requires a separate future owner
decision before any apply. Follow-up execution needs its own exact-revision card.
AI assistance
Authored with OpenAI Codex, gpt-6.1-sol. PR governance and merge preparation by Codex.
Publication scan
publication-check/2.0-advisory build 83d9d1130377: findings=1487; matching_lines=1476. Advisory scan over the complete tracked candidate tree. No credential introduced by this diff. First 20 matches (shared-masked):
TELEGRAM_TOKEN=<<HOST>>/.env.example @<PROJECT_ID>/.github/CODEOWNERS @<PROJECT_ID>/.github/workflows/ @<PROJECT_ID>/application/account_new_risk_gate_support.py @<PROJECT_ID>/application/durable_execution_commands.py @<PROJECT_ID>/application/execution_receipt_adapter.py @<PROJECT_ID>/application/execution_service.py @<PROJECT_ID>/application/execution_state.py @<PROJECT_ID>/application/longbridge_execution.py @<PROJECT_ID>/application/paper_execution_command_consumer.py @<PROJECT_ID>/application/paper_strategy_risk_state.py @<PROJECT_ID>/runtime_execution_policy.py @<PROJECT_ID>/scripts/execution_report_heartbeat.py @<PROJECT_ID>const token = <REDACTED> core.getIDToken(audienceText); // Exact bytes; URL normalization may change an audience.const <PROJECT_ID> = {...pr,head:{...pr.head,sha:pair.target},base:{...pr.base,sha:pair.base}};const binding = {...b.binding({repository:trust.repo.full_name,pr:<PROJECT_ID>,policyCommit:trust.commit,files},trust.policySha),const content='<PROJECT_ID> source\n', sourceSHA='d'.repeat(40);const pr={number:7,changed_files:1,commits:1,title:'<PROJECT_ID> change',body:'<PROJECT_ID> body',assert.equal(audience,'https://audience.example.test');return '<PROJECT_ID>-only';},summary};