Repository navigation
fix: Categorize paper IAM HTTP failures safely - #718
Merged
Merged
Conversation
Collaborator
Author
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Pigbibi
marked this pull request as ready for review
November 6, 2026 13:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Codex (GPT-6).
What changed
Add fixed HTTP failure categories for 401, 403, 429, 5xx and other errors in the bounded PAPER IAM adapter. Preserve fixed phase labels, accepted role-GET 404, transport separation, exit 1, no retry, and all authorization/mutation gates. Only the script and its existing focused tests change.
How verified
First 20 masked tracked-tree matches (pre-existing; advisory):
repo/.env.example:21:TELEGRAM_TOKEN=<<HOST>>repo/.github/CODEOWNERS:7:/.env.example @<PROJECT_ID>repo/.github/CODEOWNERS:8:/.github/CODEOWNERS @<PROJECT_ID>repo/.github/CODEOWNERS:9:/.github/workflows/ @<PROJECT_ID>repo/.github/CODEOWNERS:10:/application/account_new_risk_gate_support.py @<PROJECT_ID>repo/.github/CODEOWNERS:11:/application/durable_execution_commands.py @<PROJECT_ID>repo/.github/CODEOWNERS:12:/application/execution_receipt_adapter.py @<PROJECT_ID>repo/.github/CODEOWNERS:13:/application/execution_service.py @<PROJECT_ID>repo/.github/CODEOWNERS:14:/application/execution_state.py @<PROJECT_ID>repo/.github/CODEOWNERS:15:/application/longbridge_execution.py @<PROJECT_ID>repo/.github/CODEOWNERS:16:/application/paper_execution_command_consumer.py @<PROJECT_ID>repo/.github/CODEOWNERS:17:/application/paper_strategy_risk_state.py @<PROJECT_ID>repo/.github/CODEOWNERS:18:/runtime_execution_policy.py @<PROJECT_ID>repo/.github/CODEOWNERS:19:/scripts/execution_report_heartbeat.py @<PROJECT_ID>repo/.github/dot-review/review.cjs:106:const token = <REDACTED> core.getIDToken(audienceText); // Exact bytes; URL normalization may change an audience.repo/.github/dot-review/review.cjs:190:const <PROJECT_ID> = {...pr,head:{...pr.head,sha:pair.target},base:{...pr.base,sha:pair.base}};repo/.github/dot-review/review.cjs:191:const binding = {...b.binding({repository:trust.repo.full_name,pr:<PROJECT_ID>,policyCommit:trust.commit,files},trust.policySha),repo/.github/dot-review/test-review.cjs:81:const content='<PROJECT_ID> source\n', sourceSHA='d'.repeat(40);repo/.github/dot-review/test-review.cjs:82:const pr={number:7,changed_files:1,commits:1,title:'<PROJECT_ID> change',body:'<PROJECT_ID> body',repo/.github/dot-review/test-review.cjs:100:assert.equal(audience,'https://audience.example.test');return '<PROJECT_ID>-only';},summary};Why
The previously failed read emitted phase=role_get but discarded HTTP status, so the available evidence cannot distinguish authorization rejection from throttling or server failure. The existing phase observability change did not retain a status category. This patch makes a separately authorized future dry-run diagnosable without logging remote diagnostics. It does not establish the status of the historical failure or prove a missing permission.
Risk
Bounded diagnostic change on a protected operational path. No workflow/permission changes. No dry-run/apply dispatch, cloud/IAM/Env/Secret mutations, PAPER start, labels, undraft or merge. iam_apply=0; cloud_mutations=0; actions_*_dispatches=0; READY_FOR_START_CARD=false. PAPER remains stopped per task baseline; runtime was not inspected. No IAM grant card; permission need remains NOT_PROVEN. Coordinator must obtain a separate exact-revision review/merge card, followed by a separate ONE dry-run card; no apply implied.