Repository navigation
fix: Expose safe IAM read failure diagnostics - #717
Merged
Merged
Conversation
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Pigbibi
marked this pull request as ready for review
November 6, 2026 12:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
The IAM script hides every failure behind one generic diagnostic. Emit only a literal allowlisted Blocked category and read phase (token acquisition, role GET, getIamPolicy), with a fixed unknown fallback. Convert token subprocess failures to a fixed authentication category without exposing stderr.
Authority checks, dry-run/apply gates, mutation logic, exit status 1, single-attempt requests and no-retry behavior are preserved. Only the script and its offline tests change. No workflow dispatch, IAM operation, environment/secret update or PAPER start was performed.
Validation
uv sync --frozen --extra test): full pytest suite 3172 passed, 1 skipped, 431 subtests passed; Ruff passed; Node contracts 11 passed; diff check passed; documentation check 0 blocking / 1 existing advisory.First 20 central-checker matches (shared-masker output):
[ { "file": ".env.example", "line": 21, "text": "TELEGRAM_TOKEN=<<HOST>>" }, { "file": ".<PROJECT_ID>/CODEOWNERS", "line": 7, "text": "/.env.example @<PROJECT_ID>" }, { "file": ".<PROJECT_ID>/CODEOWNERS", "line": 8, "text": "/.github/CODEOWNERS @<PROJECT_ID>" }, { "file": ".<PROJECT_ID>/CODEOWNERS", "line": 9, "text": "/.github/workflows/ @<PROJECT_ID>" }, { "file": ".<PROJECT_ID>/CODEOWNERS", "line": 10, "text": "/application/account_new_risk_gate_support.py @<PROJECT_ID>" }, { "file": ".<PROJECT_ID>/CODEOWNERS", "line": 11, "text": "/application/durable_execution_commands.py @<PROJECT_ID>" }, { "file": ".<PROJECT_ID>/CODEOWNERS", "line": 12, "text": "/application/execution_receipt_adapter.py @<PROJECT_ID>" }, { "file": ".<PROJECT_ID>/CODEOWNERS", "line": 13, "text": "/application/execution_service.py @<PROJECT_ID>" }, { "file": ".<PROJECT_ID>/CODEOWNERS", "line": 14, "text": "/application/execution_state.py @<PROJECT_ID>" }, { "file": ".<PROJECT_ID>/CODEOWNERS", "line": 15, "text": "/application/longbridge_execution.py @<PROJECT_ID>" }, { "file": ".<PROJECT_ID>/CODEOWNERS", "line": 16, "text": "/application/paper_execution_command_consumer.py @<PROJECT_ID>" }, { "file": ".<PROJECT_ID>/CODEOWNERS", "line": 17, "text": "/application/paper_strategy_risk_state.py @<PROJECT_ID>" }, { "file": ".<PROJECT_ID>/CODEOWNERS", "line": 18, "text": "/runtime_execution_policy.py @<PROJECT_ID>" }, { "file": ".<PROJECT_ID>/CODEOWNERS", "line": 19, "text": "/scripts/execution_report_heartbeat.py @<PROJECT_ID>" }, { "file": ".<PROJECT_ID>/dot-review/review.cjs", "line": 106, "text": " const token = <REDACTED> core.getIDToken(audienceText); // Exact bytes; URL normalization may change an audience." }, { "file": ".<PROJECT_ID>/dot-review/review.cjs", "line": 190, "text": " const <PROJECT_ID> = {...pr,head:{...pr.head,sha:pair.target},base:{...pr.base,sha:pair.base}};" }, { "file": ".<PROJECT_ID>/dot-review/review.cjs", "line": 191, "text": " const binding = {...b.binding({repository:trust.repo.full_name,pr:<PROJECT_ID>,policyCommit:trust.commit,files},trust.policySha)," }, { "file": ".<PROJECT_ID>/dot-review/test-review.cjs", "line": 81, "text": " const content='<PROJECT_ID> source\\n', sourceSHA='d'.repeat(40);" }, { "file": ".<PROJECT_ID>/dot-review/test-review.cjs", "line": 82, "text": " const pr={number:7,changed_files:1,commits:1,title:'<PROJECT_ID> change',body:'<PROJECT_ID> body'," }, { "file": ".<PROJECT_ID>/dot-review/test-review.cjs", "line": 100, "text": " assert.equal(audience,'https://audience.example.test');return '<PROJECT_ID>-only';},summary};" } ]Risk and limits
Diagnostics only; the prior remote failure remains unproven until a separately authorized future dry-run. This Draft grants no merge or execution authority. No labels or merge request are part of this job.
AI assistance
Codex, gpt-6.1-sol, implemented and verified this bounded diagnostic change.