Repository navigation
fix: Explain blocked ETF notification evidence - #986
Conversation
|
@codex review Please review exact head 968ecec against base a6a0ff4. Scope: all four changed files, including presentation redaction, target-bound identity, unknown/known block explanations, explicit run evidence and unchanged fail-closed routing. Keep this PR Draft; this request grants no merge or operational authority. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Please review exact head 12f191c after the normal main synchronization. The original four-file notification presentation delta is byte-identical, with no conflicts or implementation edits. Full suite: 6801 passed, 6 skipped, 368 subtests passed; focused 152 passed; Ruff/docs/workflow checks pass. Review the complete PR, including redaction, target-bound identity, missing evidence and unchanged execution safeguards. No merge, deployment or protected operation is authorized by this request. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
AI assistance
Codex, GPT-6.1 sol. Independent exact-head review will be requested once from the established Codex review integration; acceptance is pending.
What changed
Fix IBKR strategy-cycle incident presentation: display target-bound masked identity or exact missing identity fields; explain known block classes; preserve redacted unknown structured codes; carry explicit validated source run links or RUN_LINK_MISSING. Clarify that a snapshot proceed/no-rebalance diagnostic does not authorize execution or clear a protection block.
How verified
Tests-first reproduced the four presentation defects (17 failures / 1 pass on original main). Focused checks: 181 passed, including redaction, cross-target identity, invalid-link fallback, unchanged block classification and existing restart/dedup coverage. Frozen uv sync succeeded. Ruff, documentation and workflow shell contracts passed; one existing README documentation advisory remains. Final full suite in the frozen-lock environment: 6730 passed, 6 skipped, 368 subtests passed. Publication scan follows below.
Why
The incident adapter hard-coded unknown identity, attached operational uncertainty to every abnormal cycle, omitted known reason explanations and read only console_run_url. Appended snapshot diagnostics could appear contradictory. Source attribution is established, but the original runtime alert and its actual account/run cannot be authenticated from source or recent governance workflow metadata.
Risk
Presentation-only notification code, tests and existing documentation. No execution/risk admission, dependency pin, routing, persisted incident state or deployment configuration changes. Blocks remain actionable; unknown/missing evidence stays explicit. No Telegram query/send, deployment, Secret, IAM, Environment approval, PAPER/Live/Kelly/stop-loss action. Runtime adoption and symptom closure remain NOT_PROVEN. Keep Draft; no merge or labels by this worker.
Publication check
Central checker: publication-check/2.0-advisory, build 83d9d1130377, advisory. Full tracked candidate: 2460 matching lines, 2585 findings across 310 files. These include existing examples and fake redaction fixtures. Delta and candidate artifacts: 9 matching lines; no real credential introduced. The checker result is advisory under standing publication policy.
First 20 full-tree matches (shared-masked text):
.env.example:11:IB_GATEWAY_HOST=<PROJECT_ID>.env.example:19:TELEGRAM_TOKEN=<<HOST>>.<PROJECT_ID>/CODEOWNERS:9:/.env.example @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:10:/.github/CODEOWNERS @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:11:/application/account_new_risk_gate_support.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:12:/application/execution_kernel_adapter.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:13:/application/execution_receipt_adapter.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:14:/application/execution_service.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:15:/application/ibkr_order_execution.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:16:/application/paper_execution_admission.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:17:/application/paper_execution_command_consumer.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:18:/application/portfolio_risk_diagnostics.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:19:/application/relative_risk_preview.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:20:/application/tqqq_offline_risk.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:21:/runtime_execution_policy.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:22:/scripts/deploy_notification_only.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:23:/scripts/deploy_pilot_no_traffic.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:24:/scripts/execution_report_heartbeat.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:25:/scripts/ibkr_deployment_audit.py @<PROJECT_ID>.<PROJECT_ID>/CODEOWNERS:26:/scripts/summarize_execution_ledger_cloud.py @<PROJECT_ID>