Repository navigation
ci: Add private recovery evidence bootstrap - #983
Conversation
|
@codex review Please review the exact head |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3d4145829
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please re-review the exact current head Fail-before: 9 failed / 26 passed; focused pass-after: 93 passed. Full offline: 6691 passed, 6 skipped, 368 subtests passed. Ruff, documentation (zero blocking, one existing advisory), workflow contract and diff checks passed. Keep Draft OPEN. No merge, labels, bootstrap/recover dispatch, cloud/Environment/Secret/IAM or trading operations are included. Independent review and remote CI are not claimed complete. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Pigbibi
added
the
agent-approved
AI assistance
Codex (gpt-6.1-sol) authored this change. Exact-head re-review is requested from the established review bot; independent acceptance is pending.
What changed
Add a manual, main-only protected Actions definition for private recovery evidence: one dedicated private regional Standard GCS bucket with UBLA, enforced PAP, seven-day lifecycle, disabled versioning/soft deletion, stable pre-warm v1/v2 snapshots and create-only card/receipt objects with exact readbacks. Keep the existing recovery concurrency group, reject reruns/existing buckets, and never invoke recovery or change Cloud Run.
Resolve the configured project through Resource Manager and verify its ID/number before accepting either v1 namespace representation. Recheck approval expiry after token acquisition immediately before every bucket/object POST. Document the required read-only project lookup permission; no grant is made by this change.
Why
The existing recovery operator consumes an already approved private card. This preparatory definition supplies the missing storage/evidence path under t1319s7712. The review repairs prevent rejection of valid numeric Cloud Run namespaces and writes submitted after approval expires during authentication.
How verified
Risk
High: protected workflow/storage operator. Require native Environment protection and exact valid owner/revision authority before any later dispatch. Missing Environment binding blocks credential acquisition. Resource Manager lookup needs resourcemanager.projects.get; missing permissions fail closed. No IAM/Secret/Environment configuration is created here. Private configuration, credentials and snapshots stay private; diagnostics are fixed and redirects refused.
Bucket creation is the distributed single-use claim; unknown outcomes stop without retry, adoption, repair or deletion. Partial artifacts require private reconciliation. Approval is checked at request submission; this does not cancel an already in-flight request. Snapshot capture does not prove the US$1 incremental budget; receipts retain pricing NOT_PROVEN.
Keep OPEN Draft. No label, undraft, merge, bootstrap/recover dispatch, Cloud Run/Environment/Secret/IAM mutation or PAPER/Live/Kelly/stop-loss operation is included. Recover requires MERGED bootstrap and a separate job satisfying valid t1318s7695 bounds. Owner t1320s7734 extends the existing TTL to approximately 2026-11-07 01:49 Asia/Singapore; this engineering repair neither consumes nor extends it.
Central publication checker
publication-check/2.0-advisory build
83d9d1130377: advisory exit 0, 2456 matching lines / 2581 findings in the complete tracked candidate tree. Changed-file scan: 34 matching lines / 34 findings; script has zero matches. New test matches are fake bindings or ordinary code; existing repository matches remain outside this repair. No real credential was introduced.First 20 masked matches: