Skip to content

chore(governance): centralize PR gate and anti-leak hygiene - #538

Merged
Pigbibi merged 1 commit into
mainfrom
chore/governance-single-source
Nov 15, 2026
Merged

Pigbibi merged 1 commit into
mainfrom
chore/governance-single-source

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

AI assistance

Generated with Antigravity (Gemini) assistance and verified locally.

What changed

  • Retired .github/engineering.md and synced .github/workflows/{risk-gate,pr-review-signal,engineering-governance,docs-check}.yml, .github/ISSUE_TEMPLATE/bug_report.yml, and scripts/{check_style.py,test_style.py} from QuantStrategyLab/.github (925d718e440bd5cc7c4537ffef2fd53a2f0e654d) / Pigbibi/PrGovernance (ccda8de572d2893272b0137526ef3e2d45e5eee7).
  • Updated .github/governance/policy.json to remove hardcoded reviewer IDs in favor of review_routing, updated pinned shared Gitleaks refs / retired required-gitleaks.yml where present, standardized .gitignore with all 16 internal-note patterns, and kept concise rules in AGENTS.md / @AGENTS.md in CLAUDE.md.
  • Fixed README phase-2 style findings (moved ## License / ## 许可证 to EOF and replaced PR-diff narration / phase headings).

How verified

  • python3 -B scripts/test_style.py — passed (exit 0).
  • python3 -B scripts/check_style.py --phase 2 — passed with 0 blocking findings.
  • git diff --check origin/main, actionlint -shellcheck= -pyflakes= on changed workflows, and gitleaks protect --staged --no-banner — all passed.
  • Ran node .github/dot-review/test-review.cjs — passed.

Why

Prevent accidental leakage of internal agent plans, handoffs, and review notes, eliminate duplicated governance boilerplate across repositories, and enforce open-source documentation hygiene before merge.

Risk

Risk tier: R2 (touches .github/governance/, scripts/, and workflow files). Requires green CI, exact-head ai-review, and clearing label verification via risk-gate.

@Pigbibi

Pigbibi commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T11:40:04.263559Z ddd3772 Manual request
🔒 Security Review ✅ Completed 2026-11-15T11:43:10.290893Z ddd3772 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 84e1fd45ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 84e1fd45ef

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@Pigbibi Pigbibi added agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation and removed agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation labels Nov 15, 2026
@Pigbibi
Pigbibi force-pushed the chore/governance-single-source branch from 84e1fd4 to ddd3772 Compare November 15, 2026 11:38
@Pigbibi

Pigbibi commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: ddd3772e9a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 15, 2026
@Pigbibi
Pigbibi merged commit 603a422 into main Nov 15, 2026
12 of 13 checks passed
@Pigbibi
Pigbibi deleted the chore/governance-single-source branch November 15, 2026 11:42
@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: ddd3772e9a

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant