Repository navigation
fix: Adopt shared Cloud Run tag preflight - #524
Merged
Merged
Conversation
Contributor
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Nov 5, 2026
Co-Authored-By: Codex <noreply@openai.com>
Pigbibi
marked this pull request as ready for review
November 5, 2026 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
OpenAI Codex, using the model configured by the job runner.
What changed
Adopt the versioned
cloud-run-tags/v1preflight contract at the Firstrade diagnostic, sync-plan and retained Cloud Build boundaries. Invalid exact names and insufficient fixedcbdtag headroom now stop before planning or staging. The image-only build path checks service syntax without allocating a tag. Preserve the diagnostic constants consumed by other inspection scripts, and retain MIT provenance.The upstream QPK Draft was unavailable at adoption, so this uses the brief's bounded versioned local-copy fallback: only the shared version, 46-character budget and headroom function are copied verbatim. No runtime dependency pin changes or allocation/traffic APIs are introduced.
How verified
Why
Owner decision t1255s7222, Option B from the
cr-service-name-inventory-r1decision memo and generator inventory, authorizes this bounded caller adoption. Service renames remain deferred. Fixedcbddiagnostics refuse incompatible names and retain their zero-traffic contract.Risk
Protected deployment tooling is affected. This Draft does not merge, deploy, dispatch a workflow, change traffic, rename services or change IAM, Secrets, variables, live trading, Kelly or stop-loss switches. Offline validation does not prove deployed adoption or current cloud ownership. Existing diagnostic baseline/identity/ownership/readback gates remain required.
Central publication check (advisory)
Checker:
publication-check/2.0-advisory; build83d9d1130377; findings: 1153; matching lines: 1148. Owner rule pt1114u treats the result as advisory; no CI enforcement is changed.First 20 masked matches (file:line and masked text):